-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed ansible distribution check template error #63
base: master
Are you sure you want to change the base?
Conversation
Prior to this pull request, ansible_distribution_version was never 7. It was always 7.X so the failing part of the tests never ran. |
This fixes both: - [inkatze#42](inkatze#43): using ansible_distribution_major_version instead of ansible_distribution_version - [inkatze#62](inkatze#62): using is version instead of version_compare
When could this PR be merged, please ? |
@Mageti I couldn't wait so I forked it |
@Mageti when author will be changed back |
@kostyrev, sorry I changed the author in order to create a galaxy role. |
tests are fine
Exactly for this reason we use |
I'm already using my repo for my forked galaxy role |
This fixes both: