Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin does not honor custom CSS classes #31

Open
keyboard2000 opened this issue Dec 9, 2016 · 3 comments
Open

Plugin does not honor custom CSS classes #31

keyboard2000 opened this issue Dec 9, 2016 · 3 comments

Comments

@keyboard2000
Copy link

avatar_manager_get_avatar function is not using the $args argument from the get_avatar filter. This filter added support for $args on 4.2. Here is a link for reference:

https://developer.wordpress.org/reference/functions/get_avatar/

this is the last line of the WP get_avatar function:
return apply_filters( 'get_avatar', $avatar, $id_or_email, $args['size'], $args['default'], $args['alt'], $args );

I recommend adding $args to avatar_manager_get_avatar and to avatar_manager_get_custom_avatar. Also in avatar_manager_get_custom_avatar add support for the $args elements.

@emanueljacob
Copy link

yes please add $args. At the moment its not usable for me :(
Took me at least 1 hour to find the problem in your code...

@cdog
Copy link
Member

cdog commented Jan 11, 2018

Hello,

Thank you for getting involved!

You are right, the $args parameter is missing and not yet handled. I'll update as soon as possible the dev branch with a fix. I can't promise a date yet as I'm dealing with some other ongoing projects at the moment. I'm also planning a new release in the near future (to merge the additions intro master and hopefully to fix other issues/feature requests too).

So if you have any other suggestions feel free to comment or open new issues (bugs to fix or features you would like to have). This would help me to plan ahead. Thanks!

Best,
Cătălin

@gregBerthelot
Copy link

Please add it… waste half a day trying to get class before discovering it is not supported yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants