Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0] Potential Missing Dependency on stock_account Module in account_ux #518

Open
odoo-mastercore opened this issue May 18, 2024 · 1 comment

Comments

@odoo-mastercore
Copy link

with_valuation = self.filtered('line_ids.stock_valuation_layer_ids')

Hi @rov-adhoc and @cav-adhoc

I am reviewing a commit in account_ux/models/account_move.py, and I noticed the following code:

with_valuation = self.filtered('line_ids.stock_valuation_layer_ids')

This field in account.move is added in stock_account/models/account_move.py from the stock_account module. https://github.com/odoo/odoo/blob/56b3f6714cc66dd6533dc29605e984418fc30313/addons/stock_account/models/account_move.py#L11

However, upon reviewing the manifest.py file of the account_ux module (link), there is no dependency on the stock_account module.
https://github.com/ingadhoc/account-financial-tools/blob/17.0/account_ux/__manifest__.py

This results in a critical issue, as instances without the stock_account module installed would experience functionality problems due to this missing dependency.

@rov-adhoc
Copy link
Contributor

@odoo-mastercore Thanks! You are right! I will revert that commit!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants