Feedback on Open-stream stats

[chelliwell]

I realise this is still an Alpha feature but I thought I'd point out that, although the open-stream stats are dumped if the user hits Ctrl-C, they aren't if the process is terminated by e.g. Linux 'timeout' command.

[davidk81]

Try specifying interrupt type, eg. timeout -s SIGINT

If you plan to invoke from inside a bash script, you can try something like this.

#!/bin/bash
handler()
{
    kill -s SIGINT $PID
}

export SAT_ID=5
export STELLARSTATION_API_URL=localhost:8080
./stellarcli auth activate-api-key ./api-key.json
./stellarcli satellite open-stream --stats --proxy tcp --verbose --accepted-framing BITSTREAM $SAT_ID 2>&1  | tee log.txt &

PID=$!
trap handler SIGINT
wait $PID

[davidk81]

It does seem SIGTERM may not be triggering the cleanup sequence in code (which triggers --stats). Thanks for reporting this!

[chelliwell]

Could I make another suggestion please: the line of output per packet will be too much for us, though the "Pass summary" may be useful. Could there be a --summary option which does just the summary?

[davidk81]

i think "real time stats" outputs every 2 second at current setting (not configurable). it is triggered by a timer and not by packet.

[chelliwell]

i think "real time stats" outputs every 2 second at current setting (not configurable). it is triggered by a timer and not by packet.

Ah yes, it is. Ok - I can live with that then :)

[davidk81]

sorry i just realized, currently --stats have 2 different emit rates:

1. when --stats enabled without -v , emit rate is 500ms
2. when --stats enabled with either -v or --debug, emit rate is 2000ms

i realize this may be a confusing design, maybe we should just make it user configurable, and separating the pass summary might be a good idea.

[chelliwell]

sorry i just realized, currently --stats have 2 different emit rates:

1. when --stats enabled without -v , emit rate is 500ms
2. when --stats enabled with either -v or --debug, emit rate is 2000ms

i realize this may be a confusing design, maybe we should just make it user configurable, and separating the pass summary might be a good idea.

Can you confirm if this the behaviour on 0.8.1 please? With stats+verbose I see just the pass summary at the end; with stats+debug (with or without verbose) I additionally get the real time stats, but on every packet.
I don't really need the real time stats at all, but would like to have the pass summary.
(Verbose doesn't seem to alter any of the output at all)
I'm using it with your fakeserver docker, btw