Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conform_Dictionary table is not populated #239

Open
brindakv opened this issue Jul 30, 2024 · 2 comments
Open

Conform_Dictionary table is not populated #239

brindakv opened this issue Jul 30, 2024 · 2 comments
Assignees
Labels
bug Something isn't working Deploy

Comments

@brindakv
Copy link
Collaborator

The Conform_Dictionary table is not populated for new entries on both dev and production.

This table is supposed to get populated during the backend workflow (Submission_Complete --> HOLD and Release_Ready --> REL).

@brindakv brindakv added the bug Something isn't working label Jul 30, 2024
@svoinea
Copy link
Contributor

svoinea commented Oct 15, 2024

The code for creating the Conform_Dictionary can be seen at https://github.com/informatics-isi-edu/pdb-ihm/blob/master/scripts/pdb_processing/worker/pdb/clientlib/pdb_workflow_processing_lib/client.py#L806-L905

It is executed when the Workflow_Status was changed to SUBMIT and after the execution of the validateExportmmCIF() function.

The first thing the validateExportmmCIF() function is doing is to delete the coresponding Entry_Generated_File and Entry_Error_File entries.
That means that also the Conform_Dictionary which is referring the Entry_Generated_File will be deleted.

The validateExportmmCIF() function is called also when Workflow_Status was changed to SUBMISSION_COMPLETE and RELEASE READY.
But in that case, there is no code for creating the Conform_Dictionary.
That explains why you can see the Conform_Dictionary at mmCIF CREATED but not any more at HOLD and REL.

The solution is to define a function with the code for creating the Conform_Dictionary and to be called after validateExportmmCIF().

@brindakv
Copy link
Collaborator Author

Looks good on catalog 50.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Deploy
Projects
None yet
Development

No branches or pull requests

2 participants