Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent merging commits that contain it.only in tests #987

Open
make-github-pseudonymous-again opened this issue May 22, 2024 · 0 comments
Open

Prevent merging commits that contain it.only in tests #987

make-github-pseudonymous-again opened this issue May 22, 2024 · 0 comments
Labels
ci This issue is about continuous integration dx This is about developer experience testing This issue is about testing.

Comments

@make-github-pseudonymous-again
Copy link
Contributor

One example implementation at https://www.npmjs.com/package/eslint-plugin-no-only-tests. Ideally we would want this to run only in CI, no need to prevent PRs from containing such code BEFORE being merged. While most occurrences should be caught by coverage thresholds, better safe than sorry.

See also:
@make-github-pseudonymous-again make-github-pseudonymous-again added ci This issue is about continuous integration testing This issue is about testing. dx This is about developer experience labels May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci This issue is about continuous integration dx This is about developer experience testing This issue is about testing.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@make-github-pseudonymous-again