From 62c6acba53ff8b220f485a07dd8d7a74f431fd8e Mon Sep 17 00:00:00 2001 From: Venkat Venkatasubramanian Date: Tue, 17 Oct 2023 17:18:42 -0700 Subject: [PATCH 1/4] Update test.yml --- .github/workflows/test.yml | 5 ----- 1 file changed, 5 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 482d9e80..3cbb2813 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -70,11 +70,6 @@ jobs: go mod download - name: Run tests timeout-minutes: 10 - env: - TF_ACC: "1" - B1DDI_HOST: ${{ secrets.BLOXONE_HOST }} - B1DDI_API_KEY: ${{ secrets.BLOXONE_API_KEY }} - INTERNAL_SECONDARY: ${{ secrets.INTERNAL_SECONDARY }} run: | echo ${B1DDI_HOST}, ${B1DDI_API_KEY} go test -v -cover ./b1ddi/b1ddi From cc72cf488deaf84611b8dc1262719973a78d2d94 Mon Sep 17 00:00:00 2001 From: Venkat Venkatasubramanian Date: Wed, 18 Oct 2023 10:31:24 -0700 Subject: [PATCH 2/4] Update test.yml --- .github/workflows/test.yml | 23 ++++++++++++----------- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 3cbb2813..207f8073 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -1,7 +1,5 @@ -# This GitHub action runs your tests for each commit push and/or PR. Optionally -# you can turn it on using a cron schedule for regular testing. -# -name: basic checks +# This GitHub action runs your tests for each commit push and/or PR. +name: Build on: pull_request: paths-ignore: @@ -20,7 +18,7 @@ jobs: with: go-version: '1.18' id: go - - name: Check out code into the Go module directory + - name: Check out the code into the Go module directory uses: actions/checkout@v2.4.0 - name: Get dependencies run: | @@ -28,7 +26,7 @@ jobs: - name: Build run: | go build -v ./b1ddi/b1ddi - + lint: name: Go Linter runs-on: ubuntu-latest @@ -41,20 +39,18 @@ jobs: go-version: '1.18' id: go - - name: Check out code into the Go module directory + - name: Check out the code into the Go module directory uses: actions/checkout@v2.4.0 # Run go lint on the code - name: Run go lint run: | curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.54.2 - golangci-lint run --max-issues-per-linter 0 --max-same-issues 0 --timeout 10m - + tests: name: Terraform acceptance tests runs-on: ubuntu-latest - timeout-minutes: 10 environment: testing needs: build steps: @@ -63,13 +59,18 @@ jobs: with: go-version: '1.18' id: go - - name: Check out code into the Go module directory + - name: Check out the code into the Go module directory uses: actions/checkout@v2.4.0 - name: Get dependencies run: | go mod download - name: Run tests timeout-minutes: 10 + env: + TF_ACC: "1" + B1DDI_HOST: ${{ secrets.BLOXONE_HOST }} + B1DDI_API_KEY: ${{ secrets.BLOXONE_API_KEY }} + INTERNAL_SECONDARY: ${{ secrets.INTERNAL_SECONDARY }} run: | echo ${B1DDI_HOST}, ${B1DDI_API_KEY} go test -v -cover ./b1ddi/b1ddi From 16a8d79627507a6b9c17245c19301bd2e990be24 Mon Sep 17 00:00:00 2001 From: Venkat Venkatasubramanian Date: Wed, 18 Oct 2023 10:42:22 -0700 Subject: [PATCH 3/4] Update test.yml --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 207f8073..23d2cc42 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -72,5 +72,5 @@ jobs: B1DDI_API_KEY: ${{ secrets.BLOXONE_API_KEY }} INTERNAL_SECONDARY: ${{ secrets.INTERNAL_SECONDARY }} run: | - echo ${B1DDI_HOST}, ${B1DDI_API_KEY} + env go test -v -cover ./b1ddi/b1ddi From 42817ebbae189bde7f09fd12e6540a627a76526b Mon Sep 17 00:00:00 2001 From: Venkat Venkatasubramanian Date: Wed, 18 Oct 2023 13:51:15 -0700 Subject: [PATCH 4/4] Update test.yml --- .github/workflows/test.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 23d2cc42..3fb0b386 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -70,7 +70,7 @@ jobs: TF_ACC: "1" B1DDI_HOST: ${{ secrets.BLOXONE_HOST }} B1DDI_API_KEY: ${{ secrets.BLOXONE_API_KEY }} - INTERNAL_SECONDARY: ${{ secrets.INTERNAL_SECONDARY }} + DHCP_HOST: ${{ secrets.DHCP_HOST }} + DNS_HOST: ${{ secrets.DNS_HOST }} run: | - env go test -v -cover ./b1ddi/b1ddi