chore(deps): Bump golangci-lint from v1.61.0 to v1.62.0 #16172

zak-pawel · 2024-11-10T23:02:11Z

Summary

golangci-lint bumped to v1.62.0
Matching the configuration file to the example from https://github.com/golangci/golangci-lint/blob/master/.golangci.reference.yml.
revive:max-public-structs disabled for now because of following isue: The max-public-structs rule starts finding many false positives in version 1.5.0 mgechev/revive#1103
- we should re-enable it when issues is fixed, new version of revive is released and incorporated into new golangci-lint release
Not recommended method of installing golangci-lint (from Sources) replaced for CircleCI.
- For now, I dind't change installation method for lint-install in Makefile - developers with Windows most likely will not have curl installed
- https://golangci-lint.run/welcome/install/#install-from-sources
New findings addressed:

config/config_test.go:62:2                                                    testifylint  formatter: remove unnecessary fmt.Sprintf
plugins/common/parallel/parallel_test.go:34:2                                 testifylint  formatter: remove unnecessary fmt.Sprintf
plugins/common/parallel/parallel_test.go:66:2                                 testifylint  formatter: remove unnecessary fmt.Sprintf
plugins/inputs/aliyuncms/aliyuncms_test.go:437:4                              testifylint  error-nil: use require.NoError
plugins/inputs/dcos/dcos_test.go:203:5                                        testifylint  formatter: remove unnecessary fmt.Sprintf
plugins/inputs/dcos/dcos_test.go:274:5                                        testifylint  formatter: remove unnecessary fmt.Sprintf
plugins/inputs/dcos/dcos_test.go:348:5                                        testifylint  formatter: remove unnecessary fmt.Sprintf
plugins/inputs/dcos/dcos_test.go:437:5                                        testifylint  formatter: remove unnecessary fmt.Sprintf
plugins/inputs/intel_rdt/intel_rdt_test.go:65:2                               testifylint  useless-assert: meaningless assertion
plugins/inputs/intel_rdt/intel_rdt_test.go:66:2                               testifylint  useless-assert: meaningless assertion
plugins/inputs/internal/internal_test.go:111:4                                testifylint  formatter: remove unnecessary fmt.Sprintf
plugins/inputs/postgresql_extensible/postgresql_extensible_test.go:221:3      testifylint  formatter: remove unnecessary fmt.Sprintf
plugins/inputs/postgresql_extensible/postgresql_extensible_test.go:226:3      testifylint  formatter: remove unnecessary fmt.Sprintf
plugins/inputs/postgresql_extensible/postgresql_extensible_test.go:231:3      testifylint  formatter: remove unnecessary fmt.Sprintf
plugins/inputs/postgresql_extensible/postgresql_extensible_test.go:236:3      testifylint  formatter: remove unnecessary fmt.Sprintf
plugins/inputs/vsphere/vsphere_test.go:521:2                                  testifylint  formatter: remove unnecessary fmt.Sprintf
plugins/inputs/vsphere/vsphere_test.go:624:3                                  testifylint  formatter: remove unnecessary fmt.Sprintf
plugins/inputs/win_perf_counters/win_perf_counters_integration_test.go:175:3  testifylint  useless-assert: meaningless assertion
plugins/inputs/win_perf_counters/win_perf_counters_integration_test.go:218:3  testifylint  useless-assert: meaningless assertion
plugins/inputs/win_perf_counters/win_perf_counters_integration_test.go:259:3  testifylint  useless-assert: meaningless assertion
plugins/inputs/win_perf_counters/win_perf_counters_integration_test.go:300:3  testifylint  useless-assert: meaningless assertion
plugins/inputs/win_perf_counters/win_perf_counters_integration_test.go:369:3  testifylint  useless-assert: meaningless assertion
plugins/outputs/cloudwatch/cloudwatch_test.go:71:3                            testifylint  formatter: remove unnecessary fmt.Sprintf
plugins/outputs/cloudwatch/cloudwatch_test.go:75:3                            testifylint  formatter: remove unnecessary fmt.Sprintf
plugins/outputs/cloudwatch/cloudwatch_test.go:85:2                            testifylint  formatter: remove unnecessary fmt.Sprintf
plugins/outputs/cloudwatch/cloudwatch_test.go:94:2                            testifylint  formatter: remove unnecessary fmt.Sprintf
plugins/outputs/cloudwatch/cloudwatch_test.go:108:2                           testifylint  formatter: remove unnecessary fmt.Sprintf
plugins/parsers/dropwizard/parser_test.go:114:2                               testifylint  formatter: remove unnecessary fmt.Sprintf
plugins/processors/starlark/starlark_test.go:3746:2                           testifylint  formatter: remove unnecessary fmt.Sprintf
plugins/processors/starlark/starlark_test.go:3756:3                           testifylint  formatter: remove unnecessary fmt.Sprintf
plugins/processors/starlark/starlark_test.go:3775:2                           testifylint  formatter: remove unnecessary fmt.Sprintf

Checklist

No AI generated code was used in this PR

srebhan

Thanks @zak-pawel! Can we revert the way we install the linter in CircleCI to what it was before?

srebhan · 2024-11-11T17:02:32Z

.circleci/config.yml

-          command: go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.61.0
+          command: curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.62.0


I'm not a fan of this as it opens a security risk because now everyone with write-access to that shell can execute everything in our CircleCI env. Is this really necessary?

Ok, reverted to go install

srebhan · 2024-11-11T17:04:25Z

plugins/common/parallel/parallel_test.go

@@ -31,7 +31,7 @@ func TestOrderedJobsStayOrdered(t *testing.T) {
 	p.Stop()

 	i := 0
-	require.Len(t, acc.Metrics, 20000, fmt.Sprintf("expected 20k metrics but got %d", len(acc.GetTelegrafMetrics())))
+	require.Len(t, acc.Metrics, 20000, "expected 20k metrics but got %d", len(acc.GetTelegrafMetrics()))


I think in this case you need Lenf, don't you? In any case, I would just remove the message at all as that's what Len will output anyway.

Message removed.

srebhan

Removing another message. Thanks for your work @zak-pawel!

plugins/common/parallel/parallel_test.go

telegraf-tiger · 2024-11-12T15:34:55Z

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB	RPM	TAR GZ	ZIP
amd64.deb	aarch64.rpm	darwin_amd64.tar.gz	windows_amd64.zip
arm64.deb	armel.rpm	darwin_arm64.tar.gz	windows_arm64.zip
armel.deb	armv6hl.rpm	freebsd_amd64.tar.gz	windows_i386.zip
armhf.deb	i386.rpm	freebsd_armv7.tar.gz
i386.deb	ppc64le.rpm	freebsd_i386.tar.gz
mips.deb	riscv64.rpm	linux_amd64.tar.gz
mipsel.deb	s390x.rpm	linux_arm64.tar.gz
ppc64el.deb	x86_64.rpm	linux_armel.tar.gz
riscv64.deb		linux_armhf.tar.gz
s390x.deb		linux_i386.tar.gz
		linux_mips.tar.gz
		linux_mipsel.tar.gz
		linux_ppc64le.tar.gz
		linux_riscv64.tar.gz
		linux_s390x.tar.gz

(cherry picked from commit 70e1cbc)

chore(deps): Bump golangci-lint from v1.61.0 to v1.62.0

e7c1ecb

telegraf-tiger bot added the chore label Nov 10, 2024

fix windows + adjust to .golangci.reference.yml

ad9c0b8

zak-pawel assigned srebhan and DStrand1 Nov 10, 2024

zak-pawel added the linter label Nov 10, 2024

zak-pawel requested review from srebhan and DStrand1 November 10, 2024 23:36

srebhan reviewed Nov 11, 2024

View reviewed changes

srebhan unassigned DStrand1 Nov 11, 2024

config+len

3521256

srebhan approved these changes Nov 12, 2024

View reviewed changes

plugins/common/parallel/parallel_test.go Outdated Show resolved Hide resolved

Update plugins/common/parallel/parallel_test.go

277c773

srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Nov 12, 2024

srebhan assigned DStrand1 and unassigned srebhan Nov 12, 2024

DStrand1 approved these changes Nov 12, 2024

View reviewed changes

DStrand1 merged commit 70e1cbc into influxdata:master Nov 12, 2024
27 checks passed

github-actions bot added this to the v1.32.3 milestone Nov 12, 2024

srebhan pushed a commit that referenced this pull request Nov 18, 2024

chore(deps): Bump golangci-lint from v1.61.0 to v1.62.0 (#16172)

7c47c52

(cherry picked from commit 70e1cbc)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(deps): Bump golangci-lint from v1.61.0 to v1.62.0 #16172

chore(deps): Bump golangci-lint from v1.61.0 to v1.62.0 #16172

zak-pawel commented Nov 10, 2024 •

edited

Loading

srebhan left a comment

srebhan Nov 11, 2024

zak-pawel Nov 11, 2024

srebhan Nov 11, 2024

zak-pawel Nov 11, 2024

srebhan left a comment

telegraf-tiger bot commented Nov 12, 2024

Artifact URLs

		command: go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.61.0
		command: curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh \| sh -s -- -b $(go env GOPATH)/bin v1.62.0

chore(deps): Bump golangci-lint from v1.61.0 to v1.62.0 #16172

chore(deps): Bump golangci-lint from v1.61.0 to v1.62.0 #16172

Conversation

zak-pawel commented Nov 10, 2024 • edited Loading

Summary

Checklist

srebhan left a comment

Choose a reason for hiding this comment

srebhan Nov 11, 2024

Choose a reason for hiding this comment

zak-pawel Nov 11, 2024

Choose a reason for hiding this comment

srebhan Nov 11, 2024

Choose a reason for hiding this comment

zak-pawel Nov 11, 2024

Choose a reason for hiding this comment

srebhan left a comment

Choose a reason for hiding this comment

telegraf-tiger bot commented Nov 12, 2024

Artifact URLs

zak-pawel commented Nov 10, 2024 •

edited

Loading