chore: Fix linter findings for revive:exported in plugins/inputs/l*
#16167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srebhan
approved these changes
Nov 11, 2024
There was a problem hiding this comment.
Thanks @zak-pawel! Just one comment about getting rid of a useless function. Approving anyway in case you want to do it in a separate PR...
plugins/inputs/lanz/lanz.go
Outdated
Comment on lines
124
to
126
| func newLanz() *Lanz { | ||
| return &Lanz{} | ||
| } |
There was a problem hiding this comment.
Do you think we can get rid of this function in the present PR?
plugins/inputs/logstash/logstash.go
Outdated
Comment on lines
125
to
127
| func (logstash *Logstash) Start(_ telegraf.Accumulator) error { | ||
| return nil | ||
| } |
There was a problem hiding this comment.
Suggested change
| func (logstash *Logstash) Start(_ telegraf.Accumulator) error { | |
| return nil | |
| } | |
| func (*Logstash) Start(telegraf.Accumulator) error { | |
| return nil | |
| } |
srebhan
added
the
ready for final review
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 👍 This pull request doesn't change the Telegraf binary size 📦 Click here to get additional PR build artifactsArtifact URLs |
DStrand1
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Address findings for revive:exported in
plugins/inputs/l*.As part of this effort for files from
plugins/inputs/l*, the following actions were taken:const,var,struct,func, etc) were changed to unexported, wherever they didn't need to be exported.Gather|Init|Start|Stop|SampleConfig|Parse|Add|Apply|Serialize|SerializeBatch|SetParser|SetParserFunc|GetState|SetState).initat the very end).It is only part of the bigger work (for issue: #15813).
After all findings of this type in whole project are handled, we can enable
revive:exportedrule ingolangci-lint.In addition:
plugins/inputs/linux_sysctl_fs/linux_sysctl_fs.gocontained a method that extracted the path to theprocdirectory fromHOST_PROC(or returned the default:/proc). This method was used by another plugin,plugins/inputs/processes/processes_notwindows.go. I moved this method tointernal/env.goand adjusted the code of all plugins which did similar things to use it. I did the same forHOST_SYS.exportedtounexportedin the interface implemented bymock, I regenerated all mocks using the latestmockery(for input plugins froma*tol*).Checklist