Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix linter findings for revive:enforce-slice-style in plugins/inputs/[e-j]* #16088

Merged

Conversation

zak-pawel
Copy link
Collaborator

Summary

Address findings for revive:enforce-slice-style in plugins/inputs/[e-j]*.

As we agreed here #15812, we will fix the errors found by the following configuration:

      - name: enforce-slice-style
        arguments: ["make"]

It is only part of the bigger work.
After all findings of this type in whole project are handled, we can enable revive:enforce-slice-style rule in golangci-lint.

Checklist

  • No AI generated code was used in this PR

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zak-pawel! Two questions about potentially unnecessary inits...

plugins/inputs/hugepages/hugepages_test.go Show resolved Hide resolved
plugins/inputs/jenkins/jenkins.go Outdated Show resolved Hide resolved
@telegraf-tiger
Copy link
Contributor

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zak-pawel!

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Oct 31, 2024
@srebhan srebhan assigned DStrand1 and unassigned srebhan Oct 31, 2024
@DStrand1 DStrand1 merged commit f8b2b0a into influxdata:master Oct 31, 2024
27 checks passed
@github-actions github-actions bot added this to the v1.32.3 milestone Oct 31, 2024
s-r-engineer pushed a commit to s-r-engineer/telegraf that referenced this pull request Nov 11, 2024
srebhan pushed a commit that referenced this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore linter ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants