-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(inputs.intel_powerstat): reduce msr read latency on preempt-rt kernels #13829
fix(inputs.intel_powerstat): reduce msr read latency on preempt-rt kernels #13829
Conversation
…rnels Using cyclictest utility from rt-tests [1] results on latency increase when telegraf is executed on a preempt-rt kernel. This increase occurs because of the concurrent read of MSR with goroutines. To fix this issue, the MSR read was changed to be sequential. [1] https://git.kernel.org/pub/scm/utils/rt-tests/rt-tests.git Signed-off-by: Alyson Deives Pereira <[email protected]>
d585543
to
9050c50
Compare
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 👍 This pull request doesn't change the Telegraf binary size 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I described background for concurrent reading in #13828, here is summary:
I'm ok with reading MSRs sequentially as long as:
- it will depend on config parameter, for example:
read_method
with possible values:concurrent
orsequential
- default will be:
concurrent
(to have calculations as precise as possible by default and also for backward compatibility) - it will be very well described in
README.md
,sample.conf
and code to show user pros and cons of each option- please search for all occurrences of
read_method
in https://github.com/influxdata/telegraf/blob/master/plugins/inputs/smart/README.md to see how it can be done
- please search for all occurrences of
HI @p-zak thanks for the explanation on MSR reads. |
Hello! I am closing this issue due to inactivity. I hope you were able to resolve your problem, if not please try posting this question in our Community Slack or Community Forums or provide additional details in this issue and reqeust that it be re-opened. Thank you! |
fixes: #13828
Using cyclictest utility from rt-tests [1] results on latency increase when telegraf is executed on a preempt-rt kernel. This increase occurs because of the concurrent read of MSR with goroutines.
To fix this issue, the MSR read was changed to be sequential.
[1] https://git.kernel.org/pub/scm/utils/rt-tests/rt-tests.git