Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config Variable and Docu are Different : resource_pool_metric_exclude #13905

Closed
Muy69 opened this issue Sep 12, 2023 · 8 comments · Fixed by #13907
Closed

Config Variable and Docu are Different : resource_pool_metric_exclude #13905

Muy69 opened this issue Sep 12, 2023 · 8 comments · Fixed by #13907
Labels
area/vsphere bug unexpected problem or unintended behavior regression something that used to work, but is now broken

Comments

@Muy69
Copy link

Muy69 commented Sep 12, 2023

Relevant telegraf.conf

The Variable in the Config for resourcepool_metric_exclude was changed in 1.28

prior 1.28
#resourcepool_metric_exclude = ["*"]

after
#resource_pool_metric_exclude = ["*"]

Telegraf will not start with the old Configs .

...
vm_metric_exclude = [""] # Exclude realtime metrics
host_metric_exclude = ["
"] # Exclude realtime metrics
datastore_metric_exclude = [""]
datacenter_metric_exclude = ["
"]
cluster_metric_exclude = [""]
** #resourcepool_metric_exclude = ["
"] **
resource_pool_metric_exclude = ["*"]
...

Logs from Telegraf

2023-09-12T10:14:02Z E! error loading config file /etc/telegraf/telegraf.conf: plugin inputs.vsphere: line 306: configuration specified the fields ["resourcepool_metric_exclude"], but they weren't used

System info

Telegraf 1.28, Ubuntu 22.04 , VM

Docker

No response

Steps to reproduce

  1. If you use the Variable as resource_pool_metric_exclude = ["*"] it will work
  2. If you have an existing / Old Config resourcepool_metric_exclude = ["*"] , it will not work .

Expected behavior

Please allign the Telegraf Docu with the Changes of the Variable in Version 1.28

resource_pool_metric_exclude

Actual behavior

Currently there is a Dokumentation to the old Variable .

resourcepool_metric_exclude

Additional info

No response

@Muy69 Muy69 added the bug unexpected problem or unintended behavior label Sep 12, 2023
@Hipska Hipska added regression something that used to work, but is now broken area/vsphere labels Sep 12, 2023
@Hipska
Copy link
Contributor

Hipska commented Sep 12, 2023

Introduced by #13905

@powersj
Copy link
Contributor

powersj commented Sep 12, 2023

Introduced by #13905

@Hipska #13905 is this issue report

I put up #13907 which updates the typo in the readme.

@Hipska
Copy link
Contributor

Hipska commented Sep 12, 2023

My bad, wrong paste. Introduced by #13720

@Hipska
Copy link
Contributor

Hipska commented Sep 12, 2023

@Muy69 what was the exact telegraf version when this config parameter worked without problems?

@Muy69
Copy link
Author

Muy69 commented Sep 12, 2023

I upgraded from 1.27.4-1 -> 1.28.0.1

@Hipska
Copy link
Contributor

Hipska commented Sep 12, 2023

But did it actually work? Or was the setting just ignored?

@Muy69
Copy link
Author

Muy69 commented Sep 12, 2023

It was ignored and I didnt receive an Error afterwards.

@Hipska
Copy link
Contributor

Hipska commented Sep 13, 2023

Okay, but now you do. Thanks for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/vsphere bug unexpected problem or unintended behavior regression something that used to work, but is now broken
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants