Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment status of gocritic checkers (group: diagnostic). #13212

Closed
zak-pawel opened this issue May 1, 2023 · 2 comments
Closed

Deployment status of gocritic checkers (group: diagnostic). #13212

zak-pawel opened this issue May 1, 2023 · 2 comments
Assignees
Labels

Comments

@zak-pawel
Copy link
Collaborator

zak-pawel commented May 1, 2023

Current status:

Checker Issue To enable? PR(s) Work finished?
appendAssign: Detects suspicious append result assignments #13171 N x Y
argOrder: Detects suspicious arguments order #13172 Y #13247 Y
badCall: Detects suspicious function calls #13173 Y #13247 Y
badCond: Detects suspicious condition expressions #13174 Y #13247 Y
badLock: Detects suspicious mutex lock/unlock operations #13175 Y #13247 Y
badRegexp: Detects suspicious regexp patterns #13176 Y #14295 Y
badSorting: Detects bad usage of sort package #13177 Y #13247 Y
badSyncOnceFunc: Detects bad usage of sync.OnceFunc #15497 Y #15511 Y
builtinShadowDecl: Detects top-level declarations that shadow the predeclared identifiers #13178 Y #13247 Y
caseOrder: Detects erroneous case order inside switch statements #13179 Y #13247 Y
codegenComment: Detects malformed 'code generated' file comments #13180 Y #13247 Y
commentedOutCode: Detects commented-out code inside function bodies #13181 Y #13714 Y
deferInLoop: Detects loops inside functions that use defer #13182 Y #13280 Y
deprecatedComment: Detects malformed 'deprecated' doc-comments #13183 Y #13714 Y
dupArg: Detects suspicious duplicated arguments #13184 Y #13713 Y
dupBranchBody: Detects duplicated branch bodies inside conditional statements #13185 Y #13247 Y
dupCase: Detects duplicated case clauses inside switch or select statements #13186 Y #13247 Y
dupSubExpr: Detects suspicious duplicated sub-expressions #13187 Y #13247 Y
dynamicFmtString: Detects suspicious formatting strings usage #13188 Y #13279 Y
emptyDecl: Detects suspicious empty declarations blocks #13189 Y #13247 Y
evalOrder: Detects unwanted dependencies on the evaluation order #13190 Y #13247 Y
exitAfterDefer: Detects calls to exit/fatal inside functions that use defer #13191 Y #13280 Y
externalErrorReassign: Detects suspicious reassigment of error from another package #13192 Y #13247 Y
filepathJoin: Detects problems in filepath.Join() function calls #13193 Y #13758 Y
flagDeref: Detects immediate dereferencing of flag package pointers #13194 N x Y
flagName: Detects suspicious flag names #13195 Y #13713 Y
mapKey: Detects suspicious map literal keys #13196 Y #13713 Y
nilValReturn: Detects return statements those results evaluate to nil #13197 Y #13247 Y
offBy1: Detects various off-by-one kind of errors #13198 Y #13713 Y
regexpPattern: Detects suspicious regexp patterns #13199 Y #13247 Y
returnAfterHttpError: Detects suspicious http.Error call without following return #13200 N x Y
sloppyLen: Detects usage of len when result is obvious or doesn’t make sense #15498 Y #15512 Y
sloppyReassign: Detects suspicious/confusing re-assignments #13201 Y #13712 Y
sloppyTestFuncName: Detects unsupported test and benchmark funcs #13202 Y #13711 (and removed here: #14742) Y
sloppyTypeAssert: Detects redundant type assertions #13203 Y #13247 Y
sortSlice: Detects suspicious sort.Slice calls #13204 Y #13247 Y
sprintfQuotedString: Detects "%s" formatting directives that can be replaced with %q #13205 Y #13279 Y
sqlQuery: Detects issue in Query() and Exec() calls #13206 Y #13247 Y
syncMapLoadAndDelete: Detects sync.Map load+delete operations that can be replaced with LoadAndDelete #13207 Y #13711 Y
truncateCmp: Detects potential truncation issues when comparing ints of different sizes #13208 Y #13711 Y
uncheckedInlineErr: Detects unchecked errors in if statements #13209 Y #13247 Y
unnecessaryDefer: Detects redundantly deferred calls #13210 Y #13280 Y
weakCond: Detects conditions that are unsafe due to not being exhaustive #13211 Y #13247 Y
@powersj
Copy link
Contributor

powersj commented May 2, 2023

next steps: review the above issues and determine course of action

I'll try to get my reviews in by EOD Monday

@srebhan srebhan removed their assignment May 17, 2023
@powersj
Copy link
Contributor

powersj commented Nov 7, 2023

I'm closing this "tracking" issue as there are only two left and we can follow up in those.

@powersj powersj closed this as not planned Won't fix, can't repro, duplicate, stale Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants