Skip to content
This repository has been archived by the owner on Mar 10, 2021. It is now read-only.

Add support for modals #167

Open
praveenperera opened this issue Aug 26, 2019 · 3 comments
Open

Add support for modals #167

praveenperera opened this issue Aug 26, 2019 · 3 comments

Comments

@praveenperera
Copy link

praveenperera commented Aug 26, 2019

I was able to get modal editing working with some simple css

#thesis-editor {
  z-index: 2000 !important;
}

However one problem I am having is that if, I make a content area that triggers the modal to open, I am unable to edit that content area without opening the modal.

My current hacky workaround with jQuery is:

$("div.thesis-content").click(function(e) {
  if ($("body").hasClass("thesis-editing")) {
    e.stopPropagation();
    e.preventDefault();
  }
});
@jamonholmgren
Copy link
Member

Hey @praveenperera ! Thanks for the issue. Sorry it's taken me so long, I've been traveling.

I'll take a look when I can -- about to head to another conference.

@jamonholmgren
Copy link
Member

Hey @praveenperera, I wonder if this workaround is sufficient for now. I'm not sure if it's worth trying to handle this case in Thesis itself. Thoughts?

@praveenperera
Copy link
Author

For me the work around is fine, we could wait and see if other people run into similar problems.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants