Skip to content
This repository has been archived by the owner on Mar 10, 2021. It is now read-only.

Images uploaded with Thesis aren't cached properly. #114

Open
silasjmatson opened this issue Jul 20, 2017 · 1 comment
Open

Images uploaded with Thesis aren't cached properly. #114

silasjmatson opened this issue Jul 20, 2017 · 1 comment

Comments

@silasjmatson
Copy link
Contributor

I'm not fully sure this is a thesis issue, but it needs more investigation.

Images were being served with Cache-Control:max-age=0, private, must-revalidate

We should either allow the Cache-Control header to be configured w/in thesis, or serve them with a Cache-Control header similar to normal assets, or set a reasonable max-age value.

@silasjmatson
Copy link
Contributor Author

One solution would be to set the 'Cache-Control' headers here: https://github.com/infinitered/thesis-phoenix/blob/master/lib/thesis/api_controller.ex#L57-L61

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant