Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix keyword parsing with ; in macros #328

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Fix keyword parsing with ; in macros #328

merged 1 commit into from
Oct 31, 2023

Conversation

pulsipher
Copy link
Collaborator

This fixes a few bugs related to handling macros with the syntax @myobject(model, expr; kwargs...).

@odow
Copy link
Contributor

odow commented Oct 30, 2023

The difference is not fun. I really wish Julia enforced ; for keyword arguments only.

@pulsipher
Copy link
Collaborator Author

The difference is not fun. I really wish Julia enforced ; for keyword arguments only.

I absolutely agree

@pulsipher pulsipher merged commit 3a512ef into master Oct 31, 2023
7 checks passed
@pulsipher pulsipher deleted the macro_kws branch October 31, 2023 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants