Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gest and benchmark in Windows CI #529

Open
IAmNotHanni opened this issue May 6, 2023 · 1 comment
Open

Fix gest and benchmark in Windows CI #529

IAmNotHanni opened this issue May 6, 2023 · 1 comment
Labels
cat:bug bug/error/mistake which limits the program prio:low This has low priority.

Comments

@IAmNotHanni
Copy link
Member

Describe The Bug

For unknown reasons, Windows CI can't compile our tests and benchmarks. For now, only Linux CI does this.

Steps To Reproduce

Try to enable tests and benchmarks in the GitHub action for Windows CI again and it will fail

Expected Behavior

Since the tests and benchmarks can be compiled in Linux CI and here on my machine with Visual Studio 2022 locally, our solution can't be fully incorrect!

Affected Code

The continuous integration (GitHub actions) for Windows (both msvc and Clang)

Operating System

windows-latest in CI

Application Version

current master

Additional Context

none

Relevant Log Output

D:\a\vulkan-renderer\vulkan-renderer\build-debug_deps\gtest-src\googletest\src\gtest-all.cc(38,10): fatal  error : 'gtest/gtest.h' file not found [D:\a\vulkan-renderer\vulkan-renderer\build-debug_deps\gtest-build\googlemock\gmock.vcxproj]
  Building Custom Rule D:/a/vulkan-renderer/vulkan-renderer/build-debug/_deps/gtest-src/googlemock/CMakeLists.txt
D:\a\vulkan-renderer\vulkan-renderer\build-debug_deps\gtest-src\googletest\src\gtest-all.cc(38,10): fatal  error : 'gtest/gtest.h' file not found [D:\a\vulkan-renderer\vulkan-renderer\build-debug_deps\gtest-build\googlemock\gmock_main.vcxproj]
@IAmNotHanni IAmNotHanni added cat:bug bug/error/mistake which limits the program org:triage labels have to be specified or checked prio:low This has low priority. and removed org:triage labels have to be specified or checked labels May 6, 2023
@IAmNotHanni
Copy link
Member Author

We should also run the tests in the CI, but not the benchmarks.
Keep in mind that our tests don't require a gpu to run!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:bug bug/error/mistake which limits the program prio:low This has low priority.
Projects
None yet
Development

No branches or pull requests

1 participant