Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable -Wall and -Wextra flags through CMake by default #505

Open
IAmNotHanni opened this issue Oct 10, 2022 · 5 comments
Open

Enable -Wall and -Wextra flags through CMake by default #505

IAmNotHanni opened this issue Oct 10, 2022 · 5 comments
Labels
cat:dev tools building/ compiling the program, cmake configuration and general development tools diff:first issue good first issue to start contributing

Comments

@IAmNotHanni
Copy link
Member

Is your feature request related to a problem?

There are some warnings which we don't see because the -Wall and -Wextra flags are not enabed by default.

Description

Pass -Wall and -Wextra through CMake by default.

Alternatives

Do not enable those flags.

Affected Code

The entire project.

Operating System

All operating systems.

Additional Context

none
@IAmNotHanni IAmNotHanni added diff:first issue good first issue to start contributing org:triage labels have to be specified or checked labels Oct 10, 2022
@IceflowRE IceflowRE added cat:dev tools building/ compiling the program, cmake configuration and general development tools and removed org:triage labels have to be specified or checked labels Oct 10, 2022
@Denisthatorf
Copy link

I want to help with this one. Can I try it ?

@IAmNotHanni
Copy link
Member Author

Hey Bojack
Thank you very much! Ofc you can :)
@yeetari proposed to make it optional though by introducing a CMake profile or CMake option. Are you on our Discord?

best regards
Johannes

@Denisthatorf
Copy link

Not yet

@Denisthatorf
Copy link

Denisthatorf commented Oct 23, 2022 •
edited
Loading

So with -Wall and -Wextra flags, I get a ton of extra messages. I think it is very smart to make it an INEXOR_BUILD_WITH_CHECK option with the default state OFF. Is it okay if I try to commit it?

@IAmNotHanni
Copy link
Member Author

Yes, pls make a pull request :)
I will work on fixing the warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cat:dev tools building/ compiling the program, cmake configuration and general development tools diff:first issue good first issue to start contributing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@IAmNotHanni @IceflowRE @Denisthatorf