Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove triangles of adjacent cubes which are not visible #475

Open
IAmNotHanni opened this issue Jun 26, 2022 · 0 comments
Open

Remove triangles of adjacent cubes which are not visible #475

IAmNotHanni opened this issue Jun 26, 2022 · 0 comments
Labels
cat:enhancement enhancement/requested feature/update of existing features feat:octree octree, cube computations

Comments

@IAmNotHanni
Copy link
Member

IAmNotHanni commented Jun 26, 2022

Is your feature request related to a problem?

We currently keep the triangles which are not visible because of adjacent cubes. If two cubes of type CubeType::SOLID are adjacent to each other, 2 * 2 = 4 triangles are never visible, but they are still being stored in the vertex buffer.

Description

We must remove those vertices which are never visible.

Alternatives

Keep the triangles, even if they are not visible, reducing rendering performance.

Affected Code

The octree code

Operating System

All operating systems

@IAmNotHanni IAmNotHanni added cat:enhancement enhancement/requested feature/update of existing features org:triage labels have to be specified or checked labels Jun 26, 2022
@IceflowRE IceflowRE added feat:octree octree, cube computations and removed org:triage labels have to be specified or checked labels Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:enhancement enhancement/requested feature/update of existing features feat:octree octree, cube computations
Projects
None yet
Development

No branches or pull requests

2 participants