Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style service related objects #52

Open
HMT-HRO-MaMe opened this issue Jul 28, 2022 · 10 comments
Open

style service related objects #52

HMT-HRO-MaMe opened this issue Jul 28, 2022 · 10 comments

Comments

@HMT-HRO-MaMe
Copy link

Hi, the style is pretty nice and modern. But I noticed that currently it's not easy to recognize where a guest of the building can get things, services or support.

How about a different style for rooms like restaurant, toilets, amphitheatre, lecturer? So they are easy to recognize and it's a tip easier to know how to get there to get what you are looking for (within the building).

@HMT-HRO-MaMe
Copy link
Author

I guess hall would be another interesting value 😉

@francois2metz
Copy link
Member

For restaurant and toilets, I would suggest to use standard POI tags such as amenity=toilets or amenity=restaurant. It will be displayed fine.

For others rooms tagged with room=servicesroom, we could style them the same color as POI. Do you have a list of rooms values that could make sense?

@HMT-HRO-MaMe
Copy link
Author

HMT-HRO-MaMe commented Aug 8, 2022

Yes true, I tagged the POIs on the indoor=room outlines and it already get's some more structures:
Screenshot 2022-08-08 at 08-58-26 indoor

When I browse trough taginfo, I tend to suggest the following which touch aspects of very different buildings like conference halls, airports, shopping malls, ...

Events

  • conference
  • amphitheatre (not sure, this is suggested by osminedit?)
  • hall
  • lobby
  • foyer
  • lounge
  • terrace

Tasks

  • class
  • auditorium
  • lecture_hall
  • library
  • seminar | seminar_room
  • laboratory
  • computer
  • studio
  • washroom
  • fitness
  • sports
  • gym
  • break
  • kitchen

Shopping

  • store
  • retail
  • commercial
  • cafe
  • cafeteria
  • restaurant

@francois2metz
Copy link
Member

I tried to style some room values on a specific branch of the plugin: https://github.com/indoorequal/mapbox-gl-indoorequal/tree/test-subclass with values "class", "laboratory", "office", "auditorium", "amphitheatre", "reception".
Here is some results on your university:

Screenshot 2022-08-08 at 22-45-48 Map with indoor
Screenshot 2022-08-08 at 22-46-04 Map with indoor

@HMT-HRO-MaMe
Copy link
Author

HMT-HRO-MaMe commented Aug 9, 2022

Looks very promising to me :-) Thank you very much!

@HMT-HRO-MaMe
Copy link
Author

So what do you think? Can you push it live? (I would like to get some feedback by other university departments if this would be a good way to show rooms)

P.S: I noticed in the screenshot, that huge halls that are mapped room=amphitheatre seem to be missing?

@francois2metz
Copy link
Member

So what do you think? Can you push it live? (I would like to get some feedback by other university departments if this would be a good way to show rooms)

I'm waiting for the new import first.

P.S: I noticed in the screenshot, that huge halls that are mapped room=amphitheatre seem to be missing?

It seems that it's tagged as indoor=yes. You should tag it as a room or similar.

@HMT-HRO-MaMe
Copy link
Author

Oh, thanks, what a stupid mistake 😞

@francois2metz
Copy link
Member

Hi @HMT-HRO-MaMe, I published the experimental style. It's live!

@HMT-HRO-MaMe
Copy link
Author

Thank you very much, this commes with really great details for our campus 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants