Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect: pass through refs #18 #5

Open
basham opened this issue Jan 28, 2019 · 2 comments
Open

Connect: pass through refs #18 #5

basham opened this issue Jan 28, 2019 · 2 comments

Comments

@basham
Copy link
Member

basham commented Jan 28, 2019

anderjak commented on Apr 30, 2018


https://reactjs.org/docs/higher-order-components.html#refs-arent-passed-through
https://reactjs.org/docs/forwarding-refs.html
Seems like this could be good to do with or after any update to React 16.3+ work.

@basham
Copy link
Member Author

basham commented Jan 28, 2019

csbasham commented on Apr 30, 2018


Earlier versions of CL3 used functional components, and we'd manually forward refs through a _ref prop. Then to make things cleaner, we converted all components to class components, so we didn't need to do manual forwarding.
https://github.iu.edu/ess-ux/components/issues/135

If we use the new React APIs, we'll have to enforce the dependency change in package.json. Is there any reason why we should hold off making React dependency changes, or do we need to figure out techniques that allow better backwards compatibility? Or, do we just say, if you need it to work with an older version of React, you need an older version of Conduit?

@basham
Copy link
Member Author

basham commented Jan 28, 2019

anderjak commented on Apr 30, 2018


If we want to use (or I suppose even if we don't) the project (https://github.com/mridgway/hoist-non-react-statics) linked by the React article in #2 Connect: copy static methods, then we could do something similar to that library and make an obvious declaration of which versions of React are supported by which versions of Conduit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant