Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TDX tdel_info_len and tdel_data_len are generated but never used #134

Open
imlk0 opened this issue Dec 28, 2022 · 0 comments
Open

TDX tdel_info_len and tdel_data_len are generated but never used #134

imlk0 opened this issue Dec 28, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@imlk0
Copy link
Collaborator

imlk0 commented Dec 28, 2022

The tdel_info_len and tdel_data_len fileds are generated in tdx-ecdsa attester.

snprintf(evidence->type, sizeof(evidence->type), "tdx_ecdsa");
evidence->tdx.tdel_info_len = tdel_info_len;
evidence->tdx.tdel_data_len = tdel_data_len;

But they are not added to the certificate.

} else if (!strcmp(cert_info->evidence.type, "tdx_ecdsa")) {
tdx_attestation_evidence_t *tdx = &cert_info->evidence.tdx;
if (!x509_extension_add(cert, tdx_quote_oid, tdx->quote, tdx->quote_len))
goto err;
} else if (!strcmp(cert_info->evidence.type, "sev_snp")) {

} else if (!strcmp(evidence->type, "tdx_ecdsa")) {
evidence->tdx.quote_len = sizeof(evidence->tdx.quote);
return find_extension_from_cert(crt, tdx_quote_oid, evidence->tdx.quote,
&evidence->tdx.quote_len);
} else if (!strcmp(evidence->type, "sgx_la")) {

@imlk0 imlk0 added the bug Something isn't working label Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant