rebar3 dependency "git_subdir" tag not supported for tag (rule: protocol_for_deps)

[kivra-pauoli]

Bug Description

#343 is not complete, in that it doesn't support tag where it supports branch.

To Reproduce

Take the test file on that pull request and replace branch with tag, here.

Expected Behavior

No function clause.

rebar3 Logs

Not applicable.

Additional Context

• OS: all
• Erlang version: all
• rebar3 version: all

[paulo-ferraz-oliveira]

I looked at rebar3's implementation, and also the documentation. Most likely I'll also pull request there to update https://github.com/erlang/rebar3/blob/main/rebar.config.sample.

[paulo-ferraz-oliveira]

rebar3 and rebar3.org have been pull requested for update. Going to import my knowledge here, now...

[paulo-ferraz-oliveira]

@elbrujohalcon, I wonder if the rule should be more permissive and allow for git:// alongside https://.

[elbrujohalcon]

@elbrujohalcon, I wonder if the rule should be more permissive and allow for git:// alongside https://.

I think that's a good idea.