From 7972ccbea8b3e63b310292b9ae09a568aa6cadf5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?B=C3=B3r=20Mil=C3=A1n?= <71042542+bormilan@users.noreply.github.com> Date: Thu, 10 Oct 2024 14:44:18 +0200 Subject: [PATCH 1/3] Update RULES.md Co-authored-by: Brujo Benavides --- RULES.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/RULES.md b/RULES.md index 6c77801d..98cfdc28 100644 --- a/RULES.md +++ b/RULES.md @@ -61,7 +61,7 @@ identified with `(since ...)` for convenience purposes. - [State Record and Type](doc_rules/elvis_style/state_record_and_type.md) - [Used Ignored Variable](doc_rules/elvis_style/used_ignored_variable.md) - [Variable Naming Convention](doc_rules/elvis_style/variable_naming_convention.md) -- [Not Use List In Init Functions](doc_rules/elvis_style/no_init_lists.md) +- [No Init Lists](doc_rules/elvis_style/no_init_lists.md) - [Prefer Unquoted Atoms](doc_rules/elvis_text_style/prefer_unquoted_atoms.md) ## `.gitignore` rules From 6348711663357c81a9ed69f4e21a5ca43600f1d1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?B=C3=B3r=20Mil=C3=A1n?= <71042542+bormilan@users.noreply.github.com> Date: Thu, 10 Oct 2024 14:44:34 +0200 Subject: [PATCH 2/3] Update doc_rules/elvis_style/no_init_lists.md Co-authored-by: Brujo Benavides --- doc_rules/elvis_style/no_init_lists.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/doc_rules/elvis_style/no_init_lists.md b/doc_rules/elvis_style/no_init_lists.md index bb9218b3..26e54a11 100644 --- a/doc_rules/elvis_style/no_init_lists.md +++ b/doc_rules/elvis_style/no_init_lists.md @@ -3,8 +3,7 @@ This warns you if you use list as a parameter in an init function in a gen_* module. [Reasoning](https://erlangforums.com/t/args-in-gen-init-1/3169/4?u=elbrujohalcon) -> Works on `.beam` file? Not really! (it consumes results Ok, but these might be unexpected, since -the files are pre-processed) +> Works on `.beam` files? Yes! ## Options From 68c8945d260b423609516b4d8389ec39dfabc4fc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?B=C3=B3r=20Mil=C3=A1n?= <71042542+bormilan@users.noreply.github.com> Date: Thu, 10 Oct 2024 14:44:50 +0200 Subject: [PATCH 3/3] Update src/elvis_style.erl Co-authored-by: Brujo Benavides --- src/elvis_style.erl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/elvis_style.erl b/src/elvis_style.erl index 1c74d8f3..914c1262 100644 --- a/src/elvis_style.erl +++ b/src/elvis_style.erl @@ -34,7 +34,7 @@ -hank([{unnecessary_function_arguments, [{no_init_lists, 3}]}]). -define(NO_INIT_LISTS_MSG, - "Don't use a list as a parameter in 'init' function at position ~p."). + "Do not use a list as the parameter for the 'init' callback at position ~p."). -define(INVALID_MACRO_NAME_REGEX_MSG, "The macro named ~p on line ~p does not respect the format " "defined by the regular expression '~p'.").