Queue Resource Release #95
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
October 29, 2010 14:54
…n_feedback_fun Add stack trace on error in feedback function
Add mockapn
…_using_erlang_r16 Compile error using Erlang R16B02 (erts-5.10.3)
See issue inaka#86.
Fix compile error using gcc 5.2
Fix sync to use rustyio/sync instead of non-existing inaka/sync
…l_has_problem apns_queue.erl has problem
When close a apns connection, the queue resource doesn't release,which leads to a lot of useless apns queue left in system that cannot be GC. Add apns_queue:stop in apns_connection:terminate can fix it.
apes:connection(error_fun/2, feedback_fun/1).
apes:connection(error_fun/2, feedback_fun/1).
| @@ -315,7 +315,8 @@ handle_info(Request, State) -> | |||
|
|
|||
| %% @hidden | |||
| -spec terminate(term(), state()) -> ok. | |||
| terminate(_Reason, _State) -> ok. | |||
| terminate(_Reason, State=#state{queue = QID}) -> | |||
There was a problem hiding this comment.
According to Elvis:
Line 318 has 1 trailing whitespace characters.
support apns:connect(ErrorFun, FeedbackFun)
device_token accept binary and list；fix some elvis errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #93 like sugus-seu#1
As @sugus-seu said: