-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Holderjs with Material Icons continued #202
Comments
@cliveb im not sure how to import with css and specify the class as is done with
seems to work, but not sure whether it can be better. |
So really it seems to me to be more of a problem with the url and font-family name, googles font servers are properly setup with CORS headers (its google after all). this minimal change should work too:
|
@mikeatm |
Thanks for CORS correct css headers for Google's material icons. Same story material icons works in html but do not work in Ivan's demo.js which I am trying to reuse as themify.js Using text= result is placeholder sizes at http://www.socialmrp.com Interesting <object data-src="holder.js/200x200?theme=vine&text= also fails in JSFiddle https://jsfiddle.net/metalcactus/2uyztnyq/23/ I changed default renderer to holderjs.run default render to renderer: 'canvas', object: 'background' at repo https://github.com/cliveb/socialmrpsite Chrome dev tools show placeholders never see the material icons fonts. Socialmrp.com almost same svg as holderjs.com *** www.socialmrp.com / themify.js *** holderjs.com / demo.js I re-read holderjs doc and stackoverflow and experimented for a solution, no luck. I am stumped? |
@cliveb its hard to see whats going on without a simple case on jsfiddle which reproduces your case, |
@mikeatm Thanks for the guidance. Made no difference setting font=Material+Icons to font=Material Icons. I will try to create a fiddle that represents (no small feat for me, I am learning a lot). |
@cliveb please use jsbin instead of jsfiddle - there's some bug causing placeholders not to render correctly (with custom fonts) on jsfiddle |
Holder with Material Icons issue started here, added this new issue to follow the new (extended) issue.
Holder with Material Icons work with external resources in html. Move Material Icons external resources to css and holderjs stops working. To illustrate added jsfiddle https://jsfiddle.net/metalcactus/2uyztnyq/8/
Remove from HTML to see mmaterial icons stop working
Also never working
Maybe this is to do with CORS http://stackoverflow.com/questions/39231412/if-i-link-to-an-external-css-on-a-remote-server-with-font-installed-will-it-emb
The text was updated successfully, but these errors were encountered: