Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running Holder.js triggers warning in Firefox: #188

Open
TheRealCuran opened this issue Jun 3, 2016 · 1 comment
Open

Running Holder.js triggers warning in Firefox: #188

TheRealCuran opened this issue Jun 3, 2016 · 1 comment
Labels
Milestone

Comments

@TheRealCuran
Copy link

When using Holder.js (2.9.3) in my project, I get

mutating the [[Prototype]] of an object will cause your code to run very slowly; instead create the object with the correct initial [[Prototype]] value using Object.create

in holder.js on line 2049:
Buffer.prototype.__proto__ = Uint8Array.prototype

This seems code you imported from somewhere else ("The buffer module from node.js, for the browser."). Maybe there is a fixed upstream version?

@imsky
Copy link
Owner

imsky commented Jun 3, 2016

will take a look, thanks for reporting

@imsky imsky added the bug label Jun 3, 2016
@imsky imsky added this to the 2.10 milestone Jun 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants