Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility of sigpy dependency with scipy 1.14.0 and numpy 2.0 #183

Open
schuenke opened this issue Jun 25, 2024 · 1 comment
Open

Comments

@schuenke
Copy link
Collaborator

The sigpy dependency is currently incompatible with the latest releases of scipy (v. 1.14.0) and numpy (v. 2.0). This leads to errors in PyPulseq when it's installed in a fresh environment. I already fixed this in sigpy (mikgroup/sigpy#143) and hope for a quick merge. If they merge it, no changes on our side should be necessary.

@schuenke schuenke assigned sravan953 and unassigned sravan953 Jun 25, 2024
@wtclarke
Copy link
Contributor

wtclarke commented Aug 8, 2024

Given that sigpy doesn't seem well maintained currently, I've submitted #188 to remove the sigpy dependency where possible and then make it an optional dependency if you want to use the make_sigpy_pulse function. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants