Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File with empty mapping should not show empty records #727

Open
chavda-bhavik opened this issue Aug 6, 2024 · 3 comments
Open

File with empty mapping should not show empty records #727

chavda-bhavik opened this issue Aug 6, 2024 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers up-for-grabs

Comments

@chavda-bhavik
Copy link
Member

Describe the bug
Impler validates empty files at first. But none of the columns are required, and the user doesn't do any mapping. The review step shows a table with empty records.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://web.impler.io
  2. Create Import with following schema,
[
  {
    "key": "Email",
    "name": "Email",
    "type": "Email",
    "alternateKeys": [],
    "isRequired": false,
    "isUnique": false,
    "isFrozen": false,
    "dateFormats": [
      "DD/MM/YYYY"
    ],
    "selectValues": []
  },
  {
    "key": "First Name",
    "name": "First Name",
    "type": "String",
    "alternateKeys": [],
    "isRequired": false,
    "isUnique": false,
    "isFrozen": false,
    "dateFormats": [
      "DD/MM/YYYY"
    ],
    "selectValues": []
  },
  {
    "key": "Last Name",
    "name": "Last Name",
    "type": "String",
    "alternateKeys": [],
    "isRequired": false,
    "isUnique": false,
    "isFrozen": false,
    "dateFormats": [
      "DD/MM/YYYY"
    ],
    "selectValues": []
  },
  {
    "key": "Company Name",
    "name": "Company Name",
    "type": "String",
    "alternateKeys": [],
    "isRequired": false,
    "isUnique": false,
    "isFrozen": false,
    "dateFormats": [
      "DD/MM/YYYY"
    ],
    "selectValues": []
  },
  {
    "key": "Twitter Handle",
    "name": "Twitter Handle",
    "type": "String",
    "alternateKeys": [],
    "isRequired": false,
    "isUnique": false,
    "isFrozen": false,
    "dateFormats": [
      "DD/MM/YYYY"
    ],
    "selectValues": []
  },
  {
    "key": "LinkedIn Handle",
    "name": "LinkedIn Handle",
    "type": "String",
    "alternateKeys": [],
    "isRequired": false,
    "isUnique": false,
    "isFrozen": false,
    "dateFormats": [
      "DD/MM/YYYY"
    ],
    "selectValues": []
  },
  {
    "key": "Lead Status",
    "name": "Lead Status",
    "type": "String",
    "alternateKeys": [],
    "isRequired": false,
    "isUnique": false,
    "isFrozen": false,
    "dateFormats": [
      "DD/MM/YYYY"
    ],
    "selectValues": []
  }
]
  1. Import data with the following file.
    Ma Contacts (sample).xlsx
  2. Do not map any columns.
  3. The review step will show empty records,
    image

Expected behavior
The review step should exclude these empty records.

Additional context
We can add check here for empty records, https://github.com/implerhq/impler.io/blob/next/apps/api/src/app/review/usecases/do-review/base-review.usecase.ts#L335

@chavda-bhavik chavda-bhavik added bug Something isn't working good first issue Good for newcomers up-for-grabs labels Aug 6, 2024
@chavda-bhavik chavda-bhavik moved this to Bugs in Roadmap Aug 6, 2024
@ChinmoyDn
Copy link

Hi @chavda-bhavik,
I would like to make an attempt at this. Could you please assign the issue to me?

@chavda-bhavik
Copy link
Member Author

Sure @ChinmoyDn Feel free to ask any questions here or in discord

@rothardo
Copy link

Hi @chavda-bhavik is this issue up for grabs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers up-for-grabs
Projects
Status: Bugs
Development

No branches or pull requests

3 participants