Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature questions: importing ABI, filtering, and logging #64

Open
0x234 opened this issue Jul 10, 2019 · 2 comments
Open

Feature questions: importing ABI, filtering, and logging #64

0x234 opened this issue Jul 10, 2019 · 2 comments

Comments

@0x234
Copy link

0x234 commented Jul 10, 2019

Firstly, I think this is a fantastic project. Thanks :). I have a couple of questions around functionality that I'm not able to determine from the documentation. Apologies if this is in the docs I have missed it.

  1. Signing a transaction that calls a function in a smart contract with data

I have a use case for Vault where I'd like to sign a transaction that calls a function in a smart contract, and passes this function a data object. It looks like the paths are defined here: https://github.com/immutability-io/vault-ethereum/blob/master/path_accounts.go#L57 which would enable me to create a :mount-path/accounts/:name/sign-tx-data API. If I proceed with implementing this where would be the best place to store the ABI for the contract I wish to interact with? Presumably I'd need to pass the ABI reference and method in the API call too?

  1. Is there a way to filter RPC calls that don't match a pattern/regex? This would be great to add another layer that prevents malicious/incorrect use.

  2. Are there per-RPC call logs?

@0x234
Copy link
Author

0x234 commented Jul 11, 2019

The more I think about this I'm not sure it's possible without forking. I'd need to use abigen to create the golang bindings from the ABI, and this would need to be compiled into vault-ethereum for use at runtime. If you guys can think of any other way let me know :)

@cypherhat
Copy link
Member

I have some ideas about Vault plugins and smart contracts. Ping me at [email protected] please - I'd like to bounce them against you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants