Revise blocks API #106
Merged
Revise blocks API #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Instead of delegating execution to BlockProcessor, UnaryBlockOperator takes care of chaining operations now: The new compute(BlockSupplier source, Interval, Object dest) method handles source interval computation, getting source data, and computing result in one go, instead of the sequential BlockProcessor API. This is much nicer. It enables pass-through operators (Convert.Identity or logging for example). It should also be easier now to extend the API to keep data on the GPU for sequences of GPU operators. * The copy/compute API all operate on Interval now. Other signatures have been removed for simplicity. With the new BlockInterval class from imglib2 core, unnecessarily converting between int[] and long[] is usually avoided.
|
This pull request has been mentioned on Image.sc Forum. There might be relevant details there: https://forum.image.sc/t/fiji-friends-weekly-dev-update-thread/103718/21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of delegating execution to
BlockProcessor,UnaryBlockOperatortakes care of chaining operations now:The new
compute(BlockSupplier source, Interval, Object dest)method handles source interval computation, getting source data, and computing result in one go, instead of the sequentialBlockProcessorAPI.This is much nicer. It enables pass-through operators (
Convert.Identityor logging for example). It should also be easier now to extend the API to keep data on the GPU for sequences of GPU operators.The
copy/computemethods all operate onIntervalnow. Other signatures have been removed for simplicity. With the newBlockIntervalclass from imglib2 core, unnecessarily converting betweenint[]andlong[]is usually avoided.