Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding modular support for custom validators #128

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

lmst2
Copy link

@lmst2 lmst2 commented Sep 28, 2020

Thank you very much for contributing to this project. You are making the world better! 🎉
You might following this template but it is not mandatory.

Proposed Changes

  • Creating the ability for developer to add their custom valitors
  • /validator.py
  • /validators

@imWildCat
Copy link
Owner

Thanks a lot for your help!

I will fix these errors within one week.

@imWildCat
Copy link
Owner

As I tried in #129, these dependencies are too problematic to fix.

I decided to migrate this repo to a better architecture:

  • Playwright: Crawler
  • Go or Rust: Proxy and validator

Please feel free to try this or wait for the next generation of Scylla

@lmst2
Copy link
Author

lmst2 commented Oct 3, 2020

Looking forward for the next gen Scylla!
Though I haven't get my hands on Go or Rust, I'll deffinetly will when the next gen Scylla is out!

@imWildCat
Copy link
Owner

Looking forward for the next gen Scylla!
Though I haven't get my hands on Go or Rust, I'll deffinetly will when the next gen Scylla is out!

Thanks for your kind words!

After other experiments, I would try https://github.com/microsoft/playwright-python first then consider a v2.

Base automatically changed from master to main March 21, 2021 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants