Workarounds to download ISIMIP data

[perrette]

The isimip download script ignore 1850 to 1860 and rcp4.5 for isimip2

First mentioned by @NiklasSchwind here. Double check and see if workarounds can be found.

[perrette]

The download script now includes rcp45 since ba46d56

The download script only download from 1980 into the future.
Should we include all data prior to 1980 ?

[NiklasSchwind]

Hey @perrette, thanks for the progress on that front.

I think we shouldn't include all data before 1980 for the CIE emulation processes, it is fine as it is done at the moment.

However, you can control the year you start the download with the historical_year_min = XXX parameter in the config file and I noticed that editing this parameter works for every option except for the minimum year 1850. So I think this should still be solved, in case anyone gets the idea to use the package just for downloading ISIMIP data (as I did :D).

[perrette]

hey niklas, i guess that's something i can look out when more prioritary issues are addressed? I'll remove from Fall 2024 deliverable for now because it seems too much of a general issue to matter for that milestone (if you think the historical_year_min parameter is confusing I'll just remove it -- I adopted that code from another project of mine and would not want it to cause additional work for reasons not strictly related to what we're after).