Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plotting functionality should join historical_activity to ACT #834

Open
glatterf42 opened this issue Apr 24, 2024 · 1 comment
Open

Plotting functionality should join historical_activity to ACT #834

glatterf42 opened this issue Apr 24, 2024 · 1 comment
Labels
enh New features & functionality reporting

Comments

@glatterf42
Copy link
Member

glatterf42 commented Apr 24, 2024

@glatterf42 and @khaeru, I needed to filter the years explicitly here, because the plotting module does not show the values in historical years, which in this case is 690. Ideally, the plot should join historical_activity (for year 690) to ACT (for years 700, 710, and 720). If not possible, the plotting should not print historical year (690) without showing any value for that, which is the default behavior now.

Originally posted by @behnam-zakeri in #815 (comment)

This was said with respect to this line.

@glatterf42 glatterf42 added the enh New features & functionality label Apr 24, 2024
@khaeru
Copy link
Member

khaeru commented Apr 24, 2024

I think we could actually make several such enhancements. For example, the default reporting config includes:

("emi", "mul", "emission_factor", "ACT"),
…but there is also a parameter:
par("historical_emission", "n type_emission type_tec type_year")

We can try to do concatenation wherever there are such pairs.

I say ‘try’ because some issues may come up:

  • In some cases the dimensionality of the historical_* parameter is mismatched with the product of 1+ variables and 0+ parameters to which it supposedly corresponds. This is true in the case above.
  • message_ix_models.report.legacy has a parameter merge_hist, which triggers concatenation of IAMC-structured time series data for pre-model periods with computed values for model periods. This points us to the possibility that a user populates both these historical time series data and the historical_* parameters with potentially different values. What should the reporting do in such cases?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enh New features & functionality reporting
Projects
None yet
Development

No branches or pull requests

2 participants