Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

message_ix.macro lacks minimal documentation #315

Closed
23 tasks
khaeru opened this issue Mar 15, 2020 · 7 comments · Fixed by #719
Closed
23 tasks

message_ix.macro lacks minimal documentation #315

khaeru opened this issue Mar 15, 2020 · 7 comments · Fixed by #719
Assignees
Labels
docs Documentation macro MACRO model or MESSAGE-MACRO link
Milestone

Comments

@khaeru
Copy link
Member

khaeru commented Mar 15, 2020

To complete the code added in #223, one or more PRs are needed to document the message_ix.macro module, including:

  • both docstrings and in-line comments for:
    • core.Scenario.add_macro()
    • macro constants: DATA_KEY, UNITS, MACRO_ITEMS, MACRO_DATA_FOR_DERIVATION, VERIFY_INPUT_DATA.
    • macro._validate_data()
    • macro.Calculate (i.e. init)
    • macro.Calculate.read_data
    • macro.Calculate._clean_model_data
    • macro.Calculate.derive_data
    • macro.Calculate._growth
    • macro.Calculate._rho
    • macro.Calculate._gdp0
    • macro.Calculate._k0
    • macro.Calculate._total_cost
    • macro.Calculate._price
    • macro.Calculate._demand
    • macro.Calculate._bconst
    • macro.Calculate._aconst
    • macro.add_model_data
    • macro.calibrate
    • All tests in test_macro.py
  • Explanatory text for new GAMS items such as these.
  • A new page in the Sphinx docs, including:
    • autodoc of all of the above.
    • Clear advertisement of any current limitations of the code, such as (per inline comment) all demands and prices are assumed to be on level='useful'.
@khaeru khaeru added the docs Documentation label Mar 15, 2020
@khaeru khaeru added this to the 3.0 milestone Mar 15, 2020
@khaeru khaeru added the macro MACRO model or MESSAGE-MACRO link label Apr 20, 2020
khaeru added a commit that referenced this issue May 29, 2020
@khaeru
Copy link
Member Author

khaeru commented Jun 7, 2020

Postponing to after v3.0.

@khaeru khaeru modified the milestones: 3.0, 3.1 Jun 7, 2020
@khaeru
Copy link
Member Author

khaeru commented Jun 10, 2020

At the moment, users can look at test_macro.py for some examples of the code in action as part of the test suite.

@khaeru khaeru pinned this issue Aug 17, 2020
@khaeru khaeru modified the milestones: 3.1, 3.2 Aug 25, 2020
@khaeru
Copy link
Member Author

khaeru commented Jan 14, 2021

No one was assigned to do this by the feature freeze for v3.2.0, so we postpone to v3.3 (or later).

@khaeru khaeru modified the milestones: 3.2, 3.3 Jan 14, 2021
@khaeru
Copy link
Member Author

khaeru commented May 24, 2021

No one was assigned to do this by the feature freeze for v3.3.0, so we postpone to v3.4 (or later).

@khaeru khaeru modified the milestones: 3.3, 3.4 May 24, 2021
@LauWien
Copy link
Contributor

LauWien commented Jan 13, 2022

Some documentation is already implemented in PR #327 (probably will be merged after this release). As for the rest, no one was assigned to do this for v3.4.0, so we postpone to v3.5 (or later).

@LauWien LauWien modified the milestones: 3.4, 3.5 Jan 13, 2022
@LauWien
Copy link
Contributor

LauWien commented Apr 22, 2022

No one was assigned to do this by the feature freeze for v3.5.0, so we postpone to v3.6 (or later).

@LauWien LauWien modified the milestones: 3.5, 3.6 Apr 22, 2022
@khaeru
Copy link
Member Author

khaeru commented Aug 17, 2022

Removing the milestone entirely. It can be re-added if/when the team decides to schedule/assign the work.

@khaeru khaeru removed this from the 3.6 milestone Aug 17, 2022
@khaeru khaeru self-assigned this Jun 15, 2023
@khaeru khaeru added this to the 3.8 milestone Jun 15, 2023
khaeru added a commit that referenced this issue Jul 20, 2023
@khaeru khaeru unpinned this issue May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation macro MACRO model or MESSAGE-MACRO link
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants