Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not compiling when "thingProperties.h" is used. #54

Open
vdv-k opened this issue Nov 4, 2023 · 4 comments
Open

Not compiling when "thingProperties.h" is used. #54

vdv-k opened this issue Nov 4, 2023 · 4 comments

Comments

@vdv-k
Copy link

vdv-k commented Nov 4, 2023

When using
#include "thingProperties.h"
#include <OpenTherm.h>
an error is generated when compiling the code.
There seems to be a redeclaration of ' READ' (already used in ThingProperties).

Probably easy to solve but I'm new to all this and don't know how. Any suggestions welcome.

@Laxilef
Copy link
Contributor

Laxilef commented Dec 20, 2023

Hey
See this PR: #57

@4310benno
Copy link

Same problem for me in iotCloud : caused by Read definition in Opentherm.h made for "backards compatability".
Solution for the time can be : comment out Read and Write declaration, and change READ in the CPP file to READ_DATA, and upload the library to IOT cloud in a zip

@Laxilef
Copy link
Contributor

Laxilef commented Feb 2, 2024

@4310benno did you use the version from the master branch?

@4310benno
Copy link

4310benno commented Feb 2, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants