Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How should UNK residues be handled in ma_alignment.sequence? #2

Open
benmwebb opened this issue Nov 19, 2021 · 2 comments
Open

How should UNK residues be handled in ma_alignment.sequence? #2

benmwebb opened this issue Nov 19, 2021 · 2 comments

Comments

@benmwebb
Copy link
Contributor

ma_alignment.sequence is described as "The target / template sequence in the multiple sequence alignment". But what should this look like if the target or template contains non-standard residues such as UNK? For example we have a model built using 4buj chain E as the template which contains a number of UNK residues. Should ma_alignment.sequence here contain X (to match entity_poly.pdbx_seq_one_letter_code_can in 4buj.cif) or (UNK) (as in entity_poly.pdbx_seq_one_letter_code) ? The latter seems more flexible but would require reader software to be a little more intelligent (since it can't assume one character = one alignment position). But since the sequence is already uniquely defined elsewhere it seems like it doesn't matter either way, just as long as it is defined.

@brindakv
Copy link
Contributor

brindakv commented Dec 2, 2021

I suggest using X instead of (UNK) so that the sequence is a string of one-letter codes as defined in the dictionary.

@benmwebb
Copy link
Contributor Author

benmwebb commented Dec 2, 2021

I suggest using X instead of (UNK) so that the sequence is a string of one-letter codes as defined in the dictionary.

Works for me - so, the canonical sequence. Can this be stated in the docs then? That should reduce the possibility of people producing files with (UNK) and friends instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants