-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is rails (gem) a necessary dependency? #126
Comments
Hello, I'm okay with it if you can prepare a PR. I specs passed I can merge it. |
Okay. I'll try it! |
Hi Igor — Thanks. This my first time contributing to a gem. I'm not unfamiliar with Ruby, i've been working on a legacy rails app for a few years. Obviously the workflow for gems is different because they must work with different versions of other gems. I forked the repo and just altered the
If I try installing that version of mysql2, it's not working yet... working on a fix for that. I'd like to learn how to contribute to gems, so I want to figure this out. But if you want to try it locally, I'm only changing the above two files, commenting out the lines to require I believe these simple changes will work, because
|
Can you try to make it work with different version of mysql2 gem? |
I will try that and report back. |
Hi Igor — that problem was because my dev environment wasn't set up fully for gem development. Branch is passing tests locally... hope to submit the PR soon. 🙂 |
Hi Igor - I hope you are well. If you have had a chance to review the PR, please let me know if there is anything I can change. |
Hi - THANK YOU for this amazing gem. I hope you are okay, if you are in Ukraine. Don't worry about this issue too much.
We are updating a legacy Rails app to Rails 6, and we are thinking to remove ActionCable and ActiveStorage from the rails app.
It's still a Rails app, of course, but this means removing the gem
rails
from our Gemfile, and replacing it with the list of Rails gem dependencies, without Rails.However — it can only build correctly if no other gem depends on Rails.
We use many gems, but the only gem we use that depends explicitly on gem
rails
israils_db
. So i'm wondering if maybe it would be possible to narrow down your gemspec to only depend onactivemodel
andactiverecord
for example (I don't actually know which parts of Rails the gem uses, other than these).This is how we're changing our Gemfile:
The text was updated successfully, but these errors were encountered: