Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Increase indent of figures #8323

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

martinthomson
Copy link
Contributor

This carries some risk, but on balance, I think that it is a good change.

We see a lot of documents that include sourcecode or ASCII art that appears at the same indent level as the rest of the text. This makes it hard to visually distinguish figures.

This increases the indent for these, where possible. It retains the indentation flexbox hack that ensures that wider figures reduce the margin.

The risk is that this will double the indent where people have manually added one. The text formatter of xml2rfc doesn't add an indent, so this is also an inconsistency in appearance. My hope is that xml2rfc will be updated to match, with people learning not to add their own indentation to documents.

This carries some risk, but on balance, I think that it is a good
change.

We see a lot of documents that include sourcecode or ASCII art that
appears at the same indent level as the rest of the text.  This makes it
hard to visually distinguish figures.

This increases the indent for these, where possible.  It retains the
indentation flexbox hack that ensures that wider figures reduce the
margin.

The risk is that this will double the indent where people have manually
added one.  The text formatter of xml2rfc doesn't add an indent, so this
is also an inconsistency in appearance.  My hope is that xml2rfc will be
updated to match, with people learning not to add their own indentation
to documents.
@martinthomson martinthomson changed the title Increase indent of figures feat: Increase indent of figures Dec 11, 2024
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.72%. Comparing base (6b77807) to head (9d7dde9).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8323   +/-   ##
=======================================
  Coverage   88.72%   88.72%           
=======================================
  Files         310      310           
  Lines       40882    40882           
=======================================
  Hits        36273    36273           
  Misses       4609     4609           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant