Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keep draft-iesg state on expiration. Update action holders. #8321

Merged
merged 6 commits into from
Dec 13, 2024
+186 −60
Merged

fix: keep draft-iesg state on expiration. Update action holders. #8321

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
141f86e
fix: keep draft-iesg state on expiration. Update action holders
rjsparks Dec 10, 2024
9e8132b
feat: task to repair docs in dead because expiry
rjsparks Dec 11, 2024
0a8c799
fix: restore all to-date flows through update_action_holders
rjsparks Dec 11, 2024
afe9a02
fix: Fetch the System user following more regular conventions
rjsparks Dec 12, 2024
8d4020a
Merge branch 'main' into idexists
rjsparks Dec 12, 2024
cb435b6
fix: better signal test
rjsparks Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions ietf/doc/tests_draft.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -845,8 +845,8 @@ def test_clean_up_draft_files(self):
self.assertTrue(not os.path.exists(os.path.join(settings.INTERNET_DRAFT_PATH, txt)))
self.assertTrue(os.path.exists(os.path.join(settings.INTERNET_DRAFT_ARCHIVE_DIR, txt)))


def test_repair_dead_on_expire(self):
@mock.patch("ietf.community.signals.notify_of_event")
def test_repair_dead_on_expire(self, mock_notify):

# Create a draft in iesg idexists - ensure it doesn't get new docevents.
# Create a draft in iesg dead with no expires within the window - ensure it doesn't get new docevents and its state doesn't change.
Expand Down Expand Up @@ -886,7 +886,11 @@ def test_repair_dead_on_expire(self):
dead_from_expires.append(d)
dead_from_expires_event_count[d] = d.docevent_set.count()

empty_outbox()
notified_during_factory_work = mock_notify.call_count
for call_args in mock_notify.call_args_list:
e = call_args.args[0]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! I had missed that call_args now has args and kwargs properties! That is so much better than call_args[0][0].

self.assertTrue(isinstance(e,DocEvent))
self.assertFalse(hasattr(e,"skip_community_list_notification"))

repair_dead_on_expire()

Expand All @@ -906,8 +910,12 @@ def test_repair_dead_on_expire(self):
d.latest_event(StateDocEvent).desc,
"IESG state changed to <b>I-D Exists</b> from Dead",
)
self.assertEqual(len(outbox), 0)

self.assertEqual(mock_notify.call_count, 4+notified_during_factory_work)
for call_args in mock_notify.call_args_list[-4:]:
e = call_args.args[0]
self.assertTrue(isinstance(e,DocEvent))
self.assertTrue(hasattr(e,"skip_community_list_notification"))
self.assertTrue(e.skip_community_list_notification)

class ExpireLastCallTests(TestCase):
def test_expire_last_call(self):
Expand Down
Loading