feat: add support for display of differing fullname and asciiFullname #8178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is used, for example, when the fullname uses extended UTF-8 characters and it's helpful to also include the asciiFullname for those who cannot read the UTF-8 name. The form is: fullname (asciiFullname) This came up in issue ietf-tools#7167, which noted that the announcement email generated when a new Internet-Draft is uploaded, it only showed the fullname despite the draft itself containing both name forms. Change the render_author_name test set for the revised name format.
| @@ -193,6 +193,9 @@ def render_author_name(author_elt): | |||
| # Use fullname attribute, if present | |||
| fullname = author_elt.attrib.get("fullname", "").strip() | |||
| if fullname: | |||
| asciifullname = author_elt.attrib.get("asciiFullname", "").strip() | |||
| if asciifullname and asciifullname != fullname: | |||
There was a problem hiding this comment.
I'm not sure that literal equality is the right test. In xml2rfc, a method is used to check whether a name is in Latin script and the ascii name is appended if not. That might better reflect when the asciiName is needed.
There was a problem hiding this comment.
We should probably look at a bunch of drafts and see how often we're going to add extra text to a name already legible to someone who can read the rest of the draft.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is used, for example, when the fullname uses extended UTF-8 characters and it's helpful to also include the asciiFullname for those who cannot read the UTF-8 name. The form is:
fullname (asciiFullname)
This came up in issue #7167, which noted that the announcement email generated when a new Internet-Draft is uploaded, it only showed the fullname despite the draft itself containing both name forms.
Change the render_author_name test set for the revised name format.