feat: django-rest-framework #8053
Draft
+1,518
−221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes response to a list instead of dict
# Conflicts: # ietf/api/urls_rpc.py # ietf/api/views_rpc.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add django-rest-framework and friends, then reimplement the existing API. Generates nearly the same API schema with a few notable exceptions:
/docare under/draftor/rfc). This is transparent when using the API generators. We should aim to end up with something logical, but it's easy to adjust.list[<id>]todict(<id>, <some complex structure>)now just returnlist[<some complex structure>]because that's easier to express.Re: the dict mapping, since refactoring those endpoints I believe I have a better idea how to wrangle DRF so I believe we could revert that API change.
The API schema can be generated by running
ietf/manage.py spectacular --file rpcapi-generated.yaml. I've temporarily committed a copy of this for comparison (though diffs are pretty noisy)