Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update nits check URL #8107

Open
1 task done
kesara opened this issue Oct 29, 2024 · 0 comments · May be fixed by #8169
Open
1 task done

Update nits check URL #8107

kesara opened this issue Oct 29, 2024 · 0 comments · May be fixed by #8169
Assignees
@kesara
Labels
enhancement New feature or request

Comments

@kesara
Copy link
Member

kesara commented Oct 29, 2024

Description

The drafts view has a link for checking nits, which currently calls the author tools by using the idnits v2 endpoint and supplying the .txt draft as the source.

We should consider updating this to use the idnits v3 endpoint, providing .xml draft as the source.

However, for drafts that lack an XML source, we may need to continue using the v2 endpoint temporarily, as idnits v3 isn’t ready to check .txt drafts yet.

Code of Conduct
@kesara kesara added the enhancement New feature or request label Oct 29, 2024
@kesara kesara moved this to Todo in IETF 121 Code Sprint Nov 3, 2024
@kesara kesara self-assigned this Nov 3, 2024
kesara added a commit to kesara/datatracker that referenced this issue Nov 3, 2024
@kesara
feat: Use idnits3 for post submission nits check
1c4752d 
Fixes ietf-tools#8107
@kesara kesara mentioned this issue Nov 3, 2024
Merged
kesara added a commit to kesara/datatracker that referenced this issue Nov 6, 2024
@kesara
feat: Use idnits3 for post submission nits check
3dd7718 
Fixes ietf-tools#8107
@kesara kesara mentioned this issue Nov 6, 2024
Merged
kesara added a commit that referenced this issue Nov 6, 2024
@kesara
feat: Use idnits3 for post submission nits check (#8166)
2fd1c1d 
Fixes #8107
kesara added a commit to kesara/datatracker that referenced this issue Nov 6, 2024
@kesara
feat: Use idnits3 for post submission nits check
d8192fa 
Fixes ietf-tools#8107
@kesara kesara linked a pull request Nov 6, 2024 that will close this issue
Open
kesara added a commit that referenced this issue Nov 19, 2024
@kesara
feat: idnits3 button (#8235)
51fd40f 
* feat: Use idnits3 for post submission nits check

Fixes #8107

* fix: Add Nits v3 button in addition to Nits button
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kesara kesara

Labels
enhancement New feature or request
Projects
IETF 121 Code Sprint
Status: In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add idnits3 for post submission nits check button kesara/datatracker
1 participant
@kesara