Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed All code for templates #7

Merged
merged 4 commits into from
Mar 27, 2024
Merged

Removed All code for templates #7

merged 4 commits into from
Mar 27, 2024

Conversation

ieedan
Copy link
Owner

@ieedan ieedan commented Mar 27, 2024

  • ik this branch is called template commands I changed my mind
  • The template file is adding unnecessary complexity and recursion to the code at pretty much the same effect to the user so Im taking it out.

Still meaningful changes here

  • Updated logo
  • Build now checks before running
  • Some improvements and refactors

ieedan added 4 commits March 27, 2024 07:52
@ieedan
Add logo and publish extension
da6cd48
@ieedan
Changed template file to Option<String>
93d1f18 
-This makes template file optional
- Next is to check against template file in check command
@ieedan
Build now runs check before building
306be44
@ieedan
Remove template stuff
46fe827 
- The template file is just a bad idea becomes recursive and just makes things more complex for no reason
@ieedan ieedan merged commit 5fe0043 into main Mar 27, 2024
1 check passed
@ieedan ieedan deleted the template-commands branch March 27, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ieedan