Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build creates incorrect Google Fonts link #663

Open
JorgeGalindo opened this issue Sep 4, 2020 · 2 comments
Open

Build creates incorrect Google Fonts link #663

JorgeGalindo opened this issue Sep 4, 2020 · 2 comments
Labels

Comments

@JorgeGalindo
Copy link

Once you build the project, the index.html pages will feature the following unreadable link:

<link rel="stylesheet" href="https:&#x2F;&#x2F;fonts.googleapis.com&#x2F;css?family&#x3D;Hanalei+Fill|Lora|Roboto|Roboto+Slab|Rockwell" />

as a result, the microsite won't be able to find the right fonts. I'm far from an expert but my guess is that it should produce a series of links instead, e.g.:

    <link rel="stylesheet" href="https://fonts.googleapis.com/css?family=Lora">
    <link rel="stylesheet" href="https://fonts.googleapis.com/css?family=Roboto">
    <link rel="stylesheet" href="https://fonts.googleapis.com/css?family=Rockwell">
    <link rel="stylesheet" href="https://fonts.googleapis.com/css?family=Roboto+Slab">

(Anyway, idyll is such a great toolbox and I'm having a great time! Thanks for all the hard work! Hope this is useful!)

@mathisonian
Copy link
Member

Thank you @JorgeGalindo! Does this result in a 404 error occurring with the example link you pasted? I know that Google did support loading multiple fonts from one URL at one point, I'm wondering if the error is due to the fact that the url is garbled, or due to the fact that we're using one link instead of multiple.

Either way, thanks for flagging this and well get a patch in as soon as possible

@mathisonian
Copy link
Member

(and thanks for your patience as I'm a little slow responding to issues, dealing with many things on my plate the last few weeks)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants