Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add github actions for testing #88

Merged
merged 26 commits into from
Nov 5, 2024
Merged

add github actions for testing #88

merged 26 commits into from
Nov 5, 2024

Conversation

wangcj05
Copy link
Collaborator


Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

close #87

What are the significant changes in functionality due to this change request?

For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual.
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Regression tests have to complete successfully.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test.
  • 6. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.

@moosebuild
Copy link

Job Test linux pull on 6e1b9d2 : invalidated by @wangcj05

@wangcj05 wangcj05 requested a review from mandd September 26, 2024 22:13
@wangcj05
Copy link
Collaborator Author

@mandd This PR is good for you to review.

- run: pwd
- run: cd .. && rm -Rf raven && git clone https://github.com/idaholab/raven.git
- run: python3 ../raven/scripts/install_plugins.py -s ${{ github.workspace }}
# test with pip install pyDOE3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this commented line correct?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

# test with pip install pyDOE3
# - run: conda create -n test_lib python=3.10 pip
# - run: conda init bash && source ~/.bashrc && conda activate test_lib
# - run: pip install pyDOE3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this commented line correct?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed.

@mandd mandd merged commit c3fc206 into devel Nov 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add GitHub Action to enable testing
3 participants