forked from googlevr/blocks
-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AssetServicesClient doesn't handle API pagination #61
Comments
andybak
changed the title
AssetServicesClient doesn't handle pagination
AssetServicesClient doesn't handle API pagination
Dec 1, 2024
andybak
added a commit
that referenced
this issue
Dec 1, 2024
andybak
added a commit
that referenced
this issue
Dec 3, 2024
andybak
added a commit
that referenced
this issue
Dec 3, 2024
andybak
added a commit
that referenced
this issue
Dec 3, 2024
As I understand it, we can close this. You're going to update open blocks, and we are not going to update the max page size here. |
Re-opening. This is a ticket on Open Blocks for something that hasn't been completed yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The Icosa API enforces a max page size of 100 but AssetServicesClient gets it's entire list of assets in one query and doesn't handle pagination. Therefore there's no way for any asset list in Blocks to have more than 100 items.
@jamesrampton - sidenote: should we increase the Icosa API limit?
The text was updated successfully, but these errors were encountered: