Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AssetServicesClient doesn't handle API pagination #61

Open
andybak opened this issue Dec 1, 2024 · 2 comments
Open

AssetServicesClient doesn't handle API pagination #61

andybak opened this issue Dec 1, 2024 · 2 comments

Comments

@andybak
Copy link

andybak commented Dec 1, 2024

The Icosa API enforces a max page size of 100 but AssetServicesClient gets it's entire list of assets in one query and doesn't handle pagination. Therefore there's no way for any asset list in Blocks to have more than 100 items.

@jamesrampton - sidenote: should we increase the Icosa API limit?

@andybak andybak changed the title AssetServicesClient doesn't handle pagination AssetServicesClient doesn't handle API pagination Dec 1, 2024
andybak added a commit that referenced this issue Dec 1, 2024
andybak added a commit that referenced this issue Dec 3, 2024
andybak added a commit that referenced this issue Dec 3, 2024
andybak added a commit that referenced this issue Dec 3, 2024
@jamesrampton
Copy link

As I understand it, we can close this. You're going to update open blocks, and we are not going to update the max page size here.

@andybak
Copy link
Author

andybak commented Dec 9, 2024

Re-opening. This is a ticket on Open Blocks for something that hasn't been completed yet.

@andybak andybak reopened this Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants