You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First, just want to thank you for such an amazing library!
Some of our users have mixed ascii and non-ascii characters in their names, e.g. Sᴀᴜʟ123, which makes the DEFAULT_CALLBACKS.matcher function's regex fail, as it will either match all ascii or all non-ascii:
I've overridden this callback for now with this regex: /(?:^|\s)@((?:([A-Za-zÀ-ÿ0-9_'.+-]|[^\x00-\xff]))*)$/, which combines the two character classes into a single capturing group.
Is there a specific reason that ascii and non-ascii groupings should be considered separate?
Again, thank you for all your work on this project :)
The text was updated successfully, but these errors were encountered:
First, just want to thank you for such an amazing library!
Some of our users have mixed ascii and non-ascii characters in their names, e.g. Sᴀᴜʟ123, which makes the
DEFAULT_CALLBACKS.matcher
function's regex fail, as it will either match all ascii or all non-ascii:At.js/src/default.coffee
Line 56 in 1b7a520
I've overridden this callback for now with this regex:
/(?:^|\s)@((?:([A-Za-zÀ-ÿ0-9_'.+-]|[^\x00-\xff]))*)$/
, which combines the two character classes into a single capturing group.Is there a specific reason that ascii and non-ascii groupings should be considered separate?
Again, thank you for all your work on this project :)
The text was updated successfully, but these errors were encountered: