How file association with database should be displayed

[peterdesmet]

Discussed on Jan 24 meeting.

A logged in user will see an overview of all uploaded files associated with their organization (even those uploaded by other users of that organization). Per file, the following information is displayed.

• fileName
• uploadDate
• uploadUser
• responsibleOrganization
• country
• count(campaigns)
• min(startDate)
• max(endDate)

Note that the last 3 (dynamic) fields are based on the associated campaigns in the database, not what is present in the file. That way, the user can always see what data in the database is associated with a file or (when no data are associated anymore) whether a file is orphaned and can be safely removed.

Scenario

1. Current overview of files

file	uploaded	by	org	country	campaigns	start	end	actions
2008_data.txt	2021-03-01	nicolas	INBO	BE	10	2008-03-02	2008-08-21	remove
2007_data.txt	2021-03-01	nicolas	INBO	BE	10	2008-04-01	2008-07-18	remove

2. I upload a new file with 3 campaigns for 2008 (3 already uploaded ones, 1 new one)
3. System asks if I want to overwrite 3 existing campaigns, I confirm
4. New overview of files:

file	uploaded	by	org	country	campaigns	start	end	actions
4 campaigns.txt	2022-01-10	peter	INBO	BE	4	2008-08-01	2008-09-01	remove
2008_data.txt	2021-03-01	nicolas	INBO	BE	7	2008-03-02	2008-07-25	remove
2007_data.txt	2021-03-01	nicolas	INBO	BE	10	2008-04-01	2008-07-18	remove

[nicolasvanermen]

Beautiful! Nicolas Vanermen *Wetenschappelijk medewerker* Instituut voor Natuur- en Bosonderzoek Havenlaan 88, bus 73, 1000 Brussel 0486/361.582

…

On Mon, Jan 24, 2022 at 11:57 AM Peter Desmet ***@***.***> wrote: Discussed on Jan 24 meeting. A logged in user will see an overview of all uploaded files associated with their organization (even those uploaded by other users of that organization). Per file, the following information is displayed. - fileName - uploadDate - uploadUser - responsibleOrganization - country - count(campaigns) - min(startDate) - max(endDate) Note that the last 3 (dynamic) fields are based on the *associated campaigns in the database*, not what is present in the file. That way, the user can always see what data in the database is associated with a file or (when no data are associated anymore) whether a file is orphaned and can be safely removed. Scenario 1. Current overview of files file uploaded by org country campaigns start end actions 2008_data.txt <#m_4387809448739602450_> 2021-03-01 nicolas INBO BE 10 2008-03-02 2008-08-21 remove <#m_4387809448739602450_> 2007_data.txt <#m_4387809448739602450_> 2021-03-01 nicolas INBO BE 10 2008-04-01 2008-07-18 remove <#m_4387809448739602450_> 1. I upload a new file with 3 campaigns for 2008 (3 already uploaded ones, 1 new one) 2. System asks if I want to overwrite 3 existing campaigns, I confirm 3. New overview of files: file uploaded by org country campaigns start end actions 4 campaigns.txt <#m_4387809448739602450_> 2022-01-10 peter INBO BE 4 2008-08-01 2008-09-01 remove <#m_4387809448739602450_> 2008_data.txt <#m_4387809448739602450_> 2021-03-01 nicolas INBO BE 7 2008-03-02 2008-07-25 remove <#m_4387809448739602450_> 2007_data.txt <#m_4387809448739602450_> 2021-03-01 nicolas INBO BE 10 2008-04-01 2008-07-18 remove <#m_4387809448739602450_> — Reply to this email directly, view it on GitHub <#67>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABYKGXNADGMTLIIGHRQ4T53UXUWCLANCNFSM5MVA7THA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[peterdesmet]

@nicolasvanermen @cmspinto is this overview of uploaded files implemented for logged in users?

[nicolasvanermen]

[nicolasvanermen]

This is the closest I can get, and still quite different from what was proposed by Peter...

[peterdesmet]

Suggested updates for the table

• Submission timestamp, not submission date
• Include number of campaigns contributed to database
• Include min date contributed to database
• Include max date contributed to database

[cmspinto]

[cmspinto]

Found a way to only give the user that uploaded the file access to the file.
Have put the validator and the handler in the page. We are not opening any security breach like this.

[peterdesmet]

@cmspinto in the Submissions table, can you:

• First have the column Data Rights Holder, then Country
• Correct Campaingns as Campaigns

[cmspinto]

Done, thanks for the heads up

[nicolasvanermen]

Important to flag here that for the moment, a logged in user can see its own submissions, but as far as I can see, there is no way for a logged in user to check which submissions have been made for the organisation the user is associated to... This will be important for the DRH's that allow me to upload their data. So a seperate page for the latter still needs to be developed...

[nicolasvanermen]

Another thing.... In the view your submissions page, the campaigns column is also referring to the number of campaigns in the database and not to the number in the file of the respective row. This can be confusing, and should be more clear based on the column name, based on a clarifying text above the table, or by listing both the number of campaigns in the file and the number in the database. So to conclude:

• develop a new page in which a user can see the files submitted for the institution (s)he is associated with
• make sure that the information in these table is interpreted correctly (cfr number of campaigns)

[peterdesmet]

Let's revisit this issue once the file screening works as expected.

[cmspinto]

@peterdesmet and @nicolasvanermen looking at the code this is already happening!

When a user click in option (c) View list of your database submissions, it shows the all user submissions and the submissions that other user(s) have done to user associated institute.

In this sense it is helpful to have a column with the submitter user name.

It is possible to do one of two things:

1. Split this page into two pages: "View list of your database submissions" and "View list of your institute submissions"

2. Rename the link to: "View list of your submissions and your institute submissions"

[cmspinto]

• make sure that the information in these table is interpreted correctly (cfr number of campaigns)

I can change the code to pick the re-submited campaigns that were removed for that file.

So either the name of the column changes to "Original No. Campaigns" or we split this into two fields, any suggestions?

[nicolasvanermen]

I would prefer two columns: No. of campaigns (database) - No. of campaigns (file)

[nicolasvanermen]

It is possible to do one of two things:

1. Split this page into two pages: "View list of your database submissions" and "View list of your institute submissions"
2. Rename the link to: "View list of your submissions and your institute submissions"

Option 1 is the most elegant

[nicolasvanermen]

@peterdesmet and @nicolasvanermen looking at the code this is already happening!

When a user click in option (c) View list of your database submissions, it shows the all user submissions and the submissions that other user(s) have done to user associated institute.

In this sense it is helpful to have a column with the submitter user name.

Yes, perfect!

[cmspinto]

Done, split into two pages:

[cmspinto]

No. of campaigns (database)

@Osanna123 needs to be tested.

[nicolasvanermen]

I can test this only partly, after I start migrating the database. But I am not planning any resubmissions, which makes it hard to test the performance of this table (cfr the number of campaigns in the database versus the number in the file).

[nicolasvanermen]

Ideally, one more test is performed after the milestone test. I will supply another datafile, including only 2 JNCC campaigns, when uploading this one, and resubmitting 2 campaigns of the first file then there should be two rows in the submissions overview, one row with 11952/11954 campaigns, and one with 2/2 campaigns. Would that be okay for you Anna?

[nicolasvanermen]

The resubmission test went fine! The only remaining issue is flagged here, closing this issue.