Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload data via the API #122

Open
peterdesmet opened this issue Sep 30, 2022 · 7 comments
Open

Upload data via the API #122

peterdesmet opened this issue Sep 30, 2022 · 7 comments

Comments

@peterdesmet
Copy link
Collaborator

@JochemBoersma, relating to your comment in #110 (comment), I'm not sure @nicolasvanermen has extensively tested uploading data via the API. @nicolasvanermen have you? Or were you using the user interface in the browser?

Note: I have tested downloading data via the API, which works fine.

@nicolasvanermen
Copy link
Collaborator

No, I have indeed been using the interface only, not being familiar with the API part of the application.

@cmspinto
Copy link
Collaborator

cmspinto commented Sep 30, 2022

This needs to be tested, but it is possible to upload data using the API.

To be able to call the submission API the user needs to have a valid token:
image

The user can ask a file to be screen with the valid token:
image

If the file is fine and the user as permission for that organization, then the file can be uploaded to the database:
image

The details are here: https://esas.ices.dk/webservices

Like @peterdesmet highlighted, this was not extensively tested but it is an advantage to have both options.

Do you @peterdesmet and @nicolasvanermen, do you think that it would be a good idea to let @JochemBoersma test the API while we are in beta and don't have production data in the database?

@peterdesmet
Copy link
Collaborator Author

peterdesmet commented Oct 3, 2022

That depends on how quickly @JochemBoersma can get the necessary credentials and test this upload feature. In my opinion, we should not wait for that, as it might delay things further and (I assume) test data uploaded by @JochemBoersma can always be deleted from the production database if needed?

@cmspinto
Copy link
Collaborator

cmspinto commented Oct 3, 2022

Yes, it can always be deleted.
I also assume that he will upload files for a distinct institution of the ones in the database?

@JochemBoersma
Copy link

Nice to hear that everything what I will upload, can be deleted. It makes it easier to play around :).
Indeed: do not wait for 'my' uploads. But nevertheless, it is a very useful use case. And I really like to assist in testing this feature.

I requested a login at [email protected] (how long does that takes, typically?), and will prepare the datasets which we have obtained.

@cmspinto
Copy link
Collaborator

cmspinto commented Oct 4, 2022

@JochemBoersma, you have a user now, please let us know if you need any further help.

Just one highlight on thing: you can submit the data for any institution but you can only resubmit data for your institution. Would you like us to give you permissions to resubmit to any institution?

@nicolasvanermen
Copy link
Collaborator

Just to notify that one of course should have some kind of approval of the institutes before uploading their data... In case anyone would ever ask ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants